Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix memory leak in FlutterSwitchSemanticsObject #28065

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Aug 13, 2021

Both methods alloc and retain will increase the reference count of _nativeSwitch,so its reference count is 2

_nativeSwitch = [[[UISwitch alloc] init] retain];

After the dealloc method is called, reference count of _nativeSwitch is 1 instead of 0, so it will not be destroyed

- (void)dealloc {
  [_nativeSwitch release];
  [super dealloc];
}

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this leak was introduced in a832502eaf

@chinmaygarde chinmaygarde added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 26, 2021
@fluttergithubbot fluttergithubbot merged commit 00bd1f4 into flutter:master Aug 26, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 26, 2021
yx-mike added a commit to yx-mike/engine that referenced this pull request Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes customer: alibaba needs tests platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants