Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Normalize the path that we set the ANDROID_HOME environment variable to #28222

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

mkustermann
Copy link
Member

The gradle/android tooling will validate that ANDROID_HOME and
ANDROID_SDK_ROOT are precisely the same. So if they point to the same
directory but are not normalized this check will fail.

Fixes Dart-Flutter Head-Head-Head bot.

The gradle/android tooling will validate that ANDROID_HOME and
ANDROID_SDK_ROOT are precisely the same. So if they point to the same
directory but are not normalized this check will fail.

Fixes Dart-Flutter Head-Head-Head bot.
@google-cla google-cla bot added the cla: yes label Aug 20, 2021
@dcharkes
Copy link
Contributor

For documentation purposes:

Several environment variables and/or system properties contain different paths to the SDK.
  Please correct and use only one way to inject the SDK location.
  
  ANDROID_HOME: /b/s/w/ir/cache/builder/engine/src/flutter/testing/rules/../../../third_party/android_tools/sdk
  ANDROID_SDK_ROOT: /b/s/w/ir/cache/builder/engine/src/third_party/android_tools/sdk

https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8838401379873295360/+/u/build_android_debug/stdout

@dcharkes dcharkes self-requested a review August 20, 2021 13:39
Copy link
Contributor

@dcharkes dcharkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkustermann mkustermann merged commit d29cda9 into master Aug 20, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 20, 2021
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Aug 23, 2021
The gradle/android tooling will validate that ANDROID_HOME and
ANDROID_SDK_ROOT are precisely the same. So if they point to the same
directory but are not normalized this check will fail.

Fixes Dart-Flutter Head-Head-Head bot which failed with
```
Several environment variables and/or system properties contain different paths to the SDK.
  Please correct and use only one way to inject the SDK location.
  
  ANDROID_HOME: /b/s/w/ir/cache/builder/engine/src/flutter/testing/rules/../../../third_party/android_tools/sdk
  ANDROID_SDK_ROOT: /b/s/w/ir/cache/builder/engine/src/third_party/android_tools/sdk
```
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
The gradle/android tooling will validate that ANDROID_HOME and
ANDROID_SDK_ROOT are precisely the same. So if they point to the same
directory but are not normalized this check will fail.

Fixes Dart-Flutter Head-Head-Head bot which failed with
```
Several environment variables and/or system properties contain different paths to the SDK.
  Please correct and use only one way to inject the SDK location.
  
  ANDROID_HOME: /b/s/w/ir/cache/builder/engine/src/flutter/testing/rules/../../../third_party/android_tools/sdk
  ANDROID_SDK_ROOT: /b/s/w/ir/cache/builder/engine/src/third_party/android_tools/sdk
```
@cbracken cbracken deleted the fix-android-env-var-mismatch branch May 10, 2022 21:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants