Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Support raw straight RGBA format in Image.toByteData() #28293

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

ColdPaleLight
Copy link
Member

@ColdPaleLight ColdPaleLight commented Aug 25, 2021

fix issue: flutter/flutter#86845

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Aug 25, 2021
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change LGTM, but don't we have to update the web interfaces as well? Why didn't this fail the conformance test?

/cc @yjbanov

@ColdPaleLight
Copy link
Member Author

ColdPaleLight commented Aug 27, 2021

This change LGTM, but don't we have to update the web interfaces as well? Why didn't this fail the conformance test?

I am trying to add this feature to the web. It seems that it can be implemented in CanvasKit, but it is difficult to implement in Html. I plan to file another PR to do this.

@ColdPaleLight
Copy link
Member Author

Hi @dnfield @yjbanov
This is the implementation in CanvasKit:#28339.
Please review it together.

Thanks

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd normally ask to throw an unimpelemented error for web but that patch will be landing soon anyway.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes customer: alibaba waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants