-
Notifications
You must be signed in to change notification settings - Fork 6k
Support raw straight RGBA format in Image.toByteData() #28293
Support raw straight RGBA format in Image.toByteData() #28293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change LGTM, but don't we have to update the web interfaces as well? Why didn't this fail the conformance test?
/cc @yjbanov
I am trying to add this feature to the web. It seems that it can be implemented in CanvasKit, but it is difficult to implement in Html. I plan to file another PR to do this. |
b12a2a0
to
501c219
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd normally ask to throw an unimpelemented error for web but that patch will be landing soon anyway.
fix issue: flutter/flutter#86845
Pre-launch Checklist
writing and running engine tests.
///
).