Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove some deprecated APIs from the Android embedding #28977

Merged
merged 4 commits into from
Oct 6, 2021

Conversation

blasten
Copy link

@blasten blasten commented Oct 1, 2021

This PR doesn't fully remove the Android embedding v1.

The goal is to fully remove the V1 embedding by EOY. cc @xster

Related issue: flutter/flutter#91069

@flutter-dashboard

This comment has been minimized.

@blasten blasten force-pushed the remove_deprecated_apis branch from 06fb2cd to c999361 Compare October 1, 2021 01:24
@blasten blasten requested a review from GaryQian October 1, 2021 01:25
Emmanuel Garcia added 2 commits September 30, 2021 18:43
@blasten blasten requested a review from jason-simmons October 5, 2021 02:01
@xster
Copy link
Member

xster commented Oct 5, 2021

Triggering a full FRoB run to see if it's still used in Google

@blasten
Copy link
Author

blasten commented Oct 5, 2021

yep. This change is waiting for the train

Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that went better than I expected :)

@blasten
Copy link
Author

blasten commented Oct 6, 2021

Not bad. PTAL @GaryQian @jason-simmons

Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One small step for the embedding, one giant leap for Android kind. (that was forced)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes needs tests platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants