This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove some deprecated APIs from the Android embedding #28977
Merged
fluttergithubbot
merged 4 commits into
flutter:master
from
blasten:remove_deprecated_apis
Oct 6, 2021
Merged
Remove some deprecated APIs from the Android embedding #28977
fluttergithubbot
merged 4 commits into
flutter:master
from
blasten:remove_deprecated_apis
Oct 6, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
06fb2cd
to
c999361
Compare
Triggering a full FRoB run to see if it's still used in Google |
yep. This change is waiting for the train |
xster
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that went better than I expected :)
Not bad. PTAL @GaryQian @jason-simmons |
GaryQian
approved these changes
Oct 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One small step for the embedding, one giant leap for Android kind. (that was forced)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 7, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 7, 2021
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
needs tests
platform-android
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't fully remove the Android embedding v1.
The goal is to fully remove the V1 embedding by EOY. cc @xster
Related issue: flutter/flutter#91069