Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] force WebGL 1 on iOS #29038

Merged
merged 1 commit into from
Oct 6, 2021
Merged

Conversation

yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Oct 6, 2021

This is a workaround for the issue described in flutter/flutter#91333.

Fixes flutter/flutter#89655

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added platform-web Code specifically for the web engine needs tests labels Oct 6, 2021
@google-cla google-cla bot added the cla: yes label Oct 6, 2021
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Also: easy to delete.

@technolion
Copy link

Is this going to be pulled into a stable 2.5.4 release?

@aytunch
Copy link

aytunch commented Nov 23, 2021

Our web app does not work on iPhone 13 Pro with iOS 15
Will this be added to the stable channel soon?
Also using WebGL 1 is not a real solution right? Is there a PR or issue which works on WebGl2 support?

@adrianjagielak
Copy link

Our web app does not work on iPhone 13 Pro with iOS 15
Will this be added to the stable channel soon?
Also using WebGL 1 is not a real solution right? Is there a PR or issue which works on WebGl2 support?

Try this: flutter/flutter#89655 (comment)

@technolion
Copy link

I just checked: this PR now part of the current flutter stable (2.10.1) 🎉

@theAugur
Copy link

Is this on stable? I am still getting this problem with stable 2.10.2... My web app won't work on iOS safari unless I build it with: flutter build web --web-renderer html --release

@daonb
Copy link

daonb commented Mar 31, 2022

iOS 15.4 fixed the safari bug and WebGL rendering works as it should.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes needs tests platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Rendering issues and crash with iOS15's Safari and new macOS Safari
7 participants