fuchsia: Enable AOT builds of Dart test packages #29048
Conversation
richkadel
force-pushed
the
enable-aot-of-flutter-embedder-test-2
branch
from
905fbb2 to
f0743c8
Compare
richkadel
changed the title
|
@arbreng - Sorry for the delay. I was hoping that I could easily see the problem running the test with release mode and fix it for this PR, but it will take more digging, and I don't want to delay re-enabling the test. CI succeeded on this PR last night on all except Android AOT, and that error appeared to be an infra failure. Re-running checks now. |
arbreng
changed the title
| @@ -65,7 +65,7 @@ third_party/gn/ | |||
| .packages | |||
| .pub-cache/ | |||
| .pub/ | |||
| build/ | |||
| */**/build/ | |||
There was a problem hiding this comment.
Can split this into it's own PR? It doesn't seem like it belongs in this change
There was a problem hiding this comment.
I put it into its own commit instead, as discussed offline
| # Product AOT | ||
| # dart_default_build_cfg = dart_release_build_cfg | ||
| # } else if (is_debug) { | ||
| # TODO(fxbug.dev/64153) renable dart runner aot builds |
There was a problem hiding this comment.
Please add a "TODO(fxbug.dev/86941) enable dart_runner_integration_tests" here
| @@ -157,10 +157,6 @@ template("dart_kernel") { | |||
| _kernel_deps += invoker.deps | |||
| } | |||
|
|
|||
| # TODO(richkadel): The manifest is currently used by flutter_dart_component, to populate the file | |||
There was a problem hiding this comment.
I think we should keep this comment
We are still having to do the non-standard code in "fuchsia_component" below, and using the "resources_in_json_file"
These comments help me track what forked-logic needs to be reconciled
There was a problem hiding this comment.
I re-added the TODO and updated it to match the current approach.
| "") | ||
|
|
||
| resources_in_json_files = [ rebase_path(_convert_kernel_manifest_file) ] | ||
| if (!build_cfg.is_aot) { |
There was a problem hiding this comment.
I think you should add a TODO(richkadel) here
This is non-standard, and I'll need to reconcile it with the build rules in the GN SDK / fuchsia somehow.
The TODO makes sure I don't forget about this later
There was a problem hiding this comment.
As discussed offline, I added a comment next to the resources_in_json_files assignment.
The integration test works in debug/jit mode only, and building in `profile` and `release` modes was not working, breaking some builders. The workaround was to disable the test. This PR will enable release/aot mode so it will build, and unblock both the debug-mode version of the test (tested by CI) and release mode builds of the repo. Due to the request to unblock, this PR does not yet build packages in `profile` mode that will run in Fuchsia, but it should at least build without errors. Ongoing work is in progress to also support running in release mode.
richkadel
force-pushed
the
enable-aot-of-flutter-embedder-test-2
branch
from
f0743c8 to
e1cf847
Compare
The integration test works in debug/jit mode only, and building in
profileandreleasemodes was not working, breaking some builders.The workaround was to disable the test.
This PR will enable release/aot mode so it will build, and unblock both
the debug-mode version of the test (tested by CI) and release mode
builds of the repo.
Due to the request to unblock, this PR does not yet build packages in
profilemode that will run in Fuchsia, but it should at least buildwithout errors. Ongoing work is in progress to also support running in
release mode.
List which issues are fixed by this PR. You must list at least one issue.
Partial fix to fxbug.dev/86055
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.