This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[fuchsia] Keep track of all child transforms in FlatlandExternalViewEmbedder #29184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
arbreng
approved these changes
Oct 14, 2021
akbiggs
approved these changes
Oct 14, 2021
…mbedder (cherry picked from commit 0adc38c375cbc982c481771e76b0a464ce95ee79)
uysalere
force-pushed
the
flatland-child-transforms
branch
from
3106dab to
f1d8779
Compare
uysalere
force-pushed
the
flatland-child-transforms
branch
from
f1d8779 to
5c5c1e1
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 21, 2021
dnfield
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 22, 2021
* 0f0b594 Roll Skia from 9cb20400599b to 05ac1b86adbb (2 revisions) (flutter/engine#29285) * d8a5433 [fuchsia] Keep track of all child transforms in FlatlandExternalViewEmbedder (flutter/engine#29184)
kylinchen
pushed a commit
to XianyuTech/engine
that referenced
this pull request
Oct 22, 2021
…mbedder (flutter#29184) * [fuchsia] Keep track of all child transforms in FlatlandExternalViewEmbedder (cherry picked from commit 0adc38c375cbc982c481771e76b0a464ce95ee79) * [fuchsia] HandleRemoveview cleanup
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Oct 29, 2021
* 0f0b594 Roll Skia from 9cb20400599b to 05ac1b86adbb (2 revisions) (flutter/engine#29285) * d8a5433 [fuchsia] Keep track of all child transforms in FlatlandExternalViewEmbedder (flutter/engine#29184)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR keeps track of all child transforms in FlatlandExternalViewEmbedder because Flatland does not have an equivalent of DetachChildren(). This used in Reset() to clean up all children.
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=64201