This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the incorrect composing region was sent as a delta to the framework, causing no delta to be created on the framework side because the delta range did not exist. Sending the correct composing region also fixes inserting of special characters with opt+n / opt+u
Also updated
testOperationsWithDelta
testOld:
New:
When
setMarkedText
is called at this point in the test, it is the beginning of composition so the text will be inserted at the collapsed selection.deltaStart
anddeltaEnd
was previously set to the range of the new composing region, but this is incorrect because the range of(14,25)
does not exist in the text before this delta is applied.Fixes flutter/flutter#101013
Added
testComposingWithDelta
Pre-launch Checklist
writing and running engine tests.
///
).