Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download EMSDK for host builders to build wasm_release #38013

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Download EMSDK for host builders to build wasm_release #38013

merged 1 commit into from
Dec 2, 2022

Conversation

harryterkelsen
Copy link
Contributor

Downloads EMSDK for the host builders.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@harryterkelsen
Copy link
Contributor Author

harryterkelsen commented Dec 1, 2022 •
edited

This is to enable building wasm_release on the host builders so we can bundle CanvasKit with flutter_web_sdk.

See https://flutter-review.git.corp.google.com/c/recipes/+/36801

@harryterkelsen harryterkelsen merged commit 6bbf3e0 into flutter:main Dec 2, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 2, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2022
@engine-flutter-autoroll
6bbf3e0e3 Download EMSDK for host builders to build wasm_release (flu…
1fdda54 
…tter/engine#38013)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 2, 2022
@engine-flutter-autoroll
Roll Flutter Engine from 8e0747cc306f to 6bbf3e0e3c8b (2 revisions) (#…
e59a388 
…116432)

* 74c943018 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter/engine#38033)

* 6bbf3e0e3 Download EMSDK for host builders to build wasm_release (flutter/engine#38013)
mit-mit pushed a commit to mit-mit/flutter that referenced this pull request Dec 6, 2022
@engine-flutter-autoroll @mit-mit
Roll Flutter Engine from 8e0747cc306f to 6bbf3e0e3c8b (2 revisions) (f…
5850225 
…lutter#116432)

* 74c943018 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter/engine#38033)

* 6bbf3e0e3 Download EMSDK for host builders to build wasm_release (flutter/engine#38013)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from 8e0747cc306f to 6bbf3e0e3c8b (2 revisions) (f…
b66ec6d 
…lutter#116432)

* 74c943018 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter/engine#38033)

* 6bbf3e0e3 Download EMSDK for host builders to build wasm_release (flutter/engine#38013)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from 8e0747cc306f to 6bbf3e0e3c8b (2 revisions) (f…
d32b455 
…lutter#116432)

* 74c943018 Roll Skia from c432cb7480b5 to 28c1bbab82b8 (2 revisions) (flutter/engine#38033)

* 6bbf3e0e3 Download EMSDK for host builders to build wasm_release (flutter/engine#38013)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@harryterkelsen @yjbanov