[ImpellerC] Print the working directory that was tried when failing to open #38079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Dec 5, 2022
impeller/compiler/switches.cc
Outdated
| @@ -196,7 +196,9 @@ bool Switches::AreValid(std::ostream& explain) const { | |||
| } | |||
|
|
|||
| if (!working_directory || !working_directory->is_valid()) { | |||
| explain << "Could not figure out working directory." << std::endl; | |||
| explain << "Could not open the working directory: " | |||
There was a problem hiding this comment.
Consider wrapping in quotes to make it clear if/when the string is empty.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 5, 2022
…116552) * 53d66aa55 [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef40 [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
mit-mit
pushed a commit
to mit-mit/flutter
that referenced
this pull request
Dec 6, 2022
…lutter#116552) * 53d66aa55 [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef40 [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#116552) * 53d66aa55 [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef40 [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116552) * 53d66aa55 [web] Add styling in CSS reset to remove Edge password reveal icon (flutter/engine#38011) * 0efb0ef40 [ImpellerC] Print the working directory that was tried when failing to open (flutter/engine#38079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, resolve the source language before attempting to open the directory, to prevent the source language error message from showing up incorrectly.