[Impeller] Remove unused flag enable-impeller-vulkan. #38109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
changed the title
|
@iskakaushik Not sure why this flag exists anymore. This doesn't do anything and I was confused when I tried to enable it on Mac and it did nothing. |
|
@chinmaygarde this should no longer be needed, there was a CI test that needed this, on macOS I haven't enabled vulkan by default yet. It is enabled on Linux. |
In that case, can we get rid of this? LGTM please :) |
iskakaushik
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
LGTM, we can land after https://flutter-review.git.corp.google.com/c/recipes/+/36980
|
@chinmaygarde as a part of this PR, could you also:
That should be all that is needed. |
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 7, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 7, 2022
…116632) * 267f0d849 Roll Skia from aea62b0970c3 to dd3285a80b23 (1 revision) (flutter/engine#38111) * 5ad341776 [Impeller] Remove unused flag enable-impeller-vulkan. (flutter/engine#38109) * 185e2f3d4 Pin the analyzer package version in lib/web_ui (flutter/engine#38114)
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#116632) * 267f0d849 Roll Skia from aea62b0970c3 to dd3285a80b23 (1 revision) (flutter/engine#38111) * 5ad341776 [Impeller] Remove unused flag enable-impeller-vulkan. (flutter/engine#38109) * 185e2f3d4 Pin the analyzer package version in lib/web_ui (flutter/engine#38114)
pbo-linaro
pushed a commit
to pbo-linaro/flutter-recipes
that referenced
this pull request
Dec 8, 2022
* also remove corresponding build * this is built by default Bug: flutter/engine#38109 Change-Id: Ic00484aa451e969252680c5b9d57cd463ab36844 Reviewed-on: https://flutter-review.googlesource.com/c/recipes/+/36980 Reviewed-by: Chinmay Garde <chinmaygarde@google.com> Reviewed-by: Zach Anderson <zra@google.com> Commit-Queue: Kaushik Iska <kaushikiska@google.com>
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#116632) * 267f0d849 Roll Skia from aea62b0970c3 to dd3285a80b23 (1 revision) (flutter/engine#38111) * 5ad341776 [Impeller] Remove unused flag enable-impeller-vulkan. (flutter/engine#38109) * 185e2f3d4 Pin the analyzer package version in lib/web_ui (flutter/engine#38114)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.