Python 3 code updates for str and byte operations #39275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoamador
requested review from
christopherfujino,
yusuf-goog and
godofredoc
ricardoamador
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 31, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 31, 2023
…119592) * 999e5e5fc Rebase all (flutter/engine#38855) * 9cc2a8e8f Update bytes str code (flutter/engine#39275) * 9448f2966 Revert "[fuchsia] Diagnostics directory rights are R* (#39203)" (flutter/engine#39271)
godofredoc
added a commit
that referenced
this pull request
Feb 7, 2023
…and … (#39443) * Update infrastructure python code to be compatible with python 2 and python 3 (#39133) * Compatibility with python2 and python3 * Formatting * Updated to use a function instead of decoding bytes in multiple places. * Formatting and whitespace cleanup. * Fix import statement. * Linter change for docstring. * Formatting. * Remove function from run_tests.py since it is a pain to import. * Add todo message for python 2 deprecation. * Updated copyright year. * Migrate engine_v2_builds to python3. (#39404) * Migrate engine_v2_builds to python3. Python2 has already been deprecated and the the python binary removed from path. * Also use python3 for global generators. * Update bytes str code (#39275) * Fix conflicts. --------- Co-authored-by: Ricardo Amador <32242716+ricardoamador@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update python subprocess checkout output code to transform output to string for regex check in CheckCIPDPackageExists method.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.