This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Match PlatformConfiguration properties to PlatformDispatcher ones #39685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
platform-web
|
/cc @ditman for web_ui changes |
loic-sharma
approved these changes
Feb 17, 2023
pdblasi-google
commented
Feb 22, 2023
ditman
reviewed
Feb 22, 2023
* Updated PlatformDispatcher to use PlatformConfiguration to back `nativeSpellCheckServiceDefined` and `brieflyShowPassword` * Updated web PlatformDispatcher/Configuration to match new API
… the same getters with exceptions.
pdblasi-google
force-pushed
the
issues/120840
branch
from
44f618f to
019c72c
Compare
|
test-exempt: code refactor with no semantic change |
pdblasi-google
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 23, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 23, 2023
…121365) * 2bc07cac7 Roll Skia from a321a8750271 to 1b2d815e9778 (5 revisions) (flutter/engine#39821) * 57cbf0858 Roll Skia from 1b2d815e9778 to fff6c987d803 (2 revisions) (flutter/engine#39823) * 2d2b51d69 Remove obsolete references in ViewConfiguration documentation (flutter/engine#39708) * cad5eec1b Match PlatformConfiguration properties to PlatformDispatcher ones (flutter/engine#39685)
jason-simmons
added a commit
to jason-simmons/flutter_engine
that referenced
this pull request
Feb 24, 2023
…ones (flutter#39685)" This reverts commit cad5eec.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativeSpellCheckServiceDefinedandbrieflyShowPasswordResolves #120840
Pre-launch Checklist
///).