Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Impeller] Remove transient usage from sampled and stored images #39957

Merged
merged 2 commits into from Mar 1, 2023
Merged

[Impeller] Remove transient usage from sampled and stored images #39957

merged 2 commits into from Mar 1, 2023

Conversation

iskakaushik
Copy link
Contributor

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@iskakaushik iskakaushik self-assigned this Feb 28, 2023
chinmaygarde
chinmaygarde reviewed Feb 28, 2023
View reviewed changes
impeller/renderer/backend/vulkan/allocator_vk.cc Outdated
@@ -132,12 +132,27 @@ static constexpr vk::ImageUsageFlags ToVKImageUsageFlags(PixelFormat format,

if (usage & static_cast<TextureUsageMask>(TextureUsage::kShaderRead)) {
vk_usage |= vk::ImageUsageFlagBits::eSampled;
// unmark the usage as transient if it is used as a sampled image
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave out the issue link as that will get outdate. Instead a comment here saying: "Device transient images can only be used as attachments. The caller specified incorrect usage flags and is attempting to read a device transient image in a shader. Unset the transient attachment flag.".

Maybe even add a validation log?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm leaving the reference to the bug and added a comment there to go back and fix the default to be kUnknown

chinmaygarde
chinmaygarde approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@chinmaygarde chinmaygarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you pushed the updates for the resolved comments. But lgtm after.

@iskakaushik iskakaushik added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2023
@iskakaushik iskakaushik merged commit ca173b4 into flutter:main Mar 1, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 1, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 1, 2023
@engine-flutter-autoroll
ca173b4cf [Impeller] Remove transient usage from sampled and stored i…
135753a 
…mages (flutter/engine#39957)
chinmaygarde pushed a commit to chinmaygarde/flutter_engine that referenced this pull request Mar 3, 2023
@iskakaushik @chinmaygarde
[Impeller] Remove transient usage from sampled and stored images (flu…
a35a3f0 
…tter#39957)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinmaygarde chinmaygarde chinmaygarde approved these changes

Assignees

@iskakaushik iskakaushik

Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
None yet
Milestone
No milestone
2 participants
@iskakaushik @chinmaygarde