Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo #39971

Merged
merged 5 commits into from Mar 2, 2023
Merged

fix typo #39971

merged 5 commits into from Mar 2, 2023

Conversation

Nayuta403
Copy link
Member

@Nayuta403 Nayuta403 commented Mar 1, 2023 •
edited

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Nayuta403 Nayuta403 requested a review from flar March 2, 2023 02:39
flar
flar requested changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no typo here that I can see. "Display" is correct. "DisPlay" is not correct.

@Nayuta403
Copy link
Member Author

@flar Get it，before is 「DispLay」 the 「L」should be lower

flar
flar approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that makes more sense now.

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 2, 2023
@auto-submit auto-submit bot merged commit 6aeb150 into flutter:main Mar 2, 2023
@Nayuta403 Nayuta403 deleted the fixtypo branch March 2, 2023 09:25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
6aeb15058 fix typo (flutter/engine#39971)
e45e3f3
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this pull request Mar 2, 2023
flutter: 6aeb15058 fix typo (flutter/engine#39971) (#121788)
bcbcdda 
Commit: 3c1f14cbae5f36a2d18b90e3a809487191c48061
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
6aeb15058 fix typo (flutter/engine#39971) (#121788)
3c1f14c 
Roll Flutter Engine from 03024a1a3742 to 6aeb15058721 (1 revision)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
286b939 
…121788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
bcddb8f 
…121788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
1e39625 
…121788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
e98c2b9 
…121788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
280a56e 
…121788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
cc9fa23 
…121788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 2, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
e0b8bc2 
…121788)
chinmaygarde pushed a commit to chinmaygarde/flutter_engine that referenced this pull request Mar 3, 2023
@Nayuta403 @chinmaygarde
fix typo (flutter#39971)
ff44214 
fix typo
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
2a94d09 
…121788)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 3, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 3, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
af08a12 
…121788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
d7cde61 
…121788)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023
@engine-flutter-autoroll
3c1f14cba 6aeb15058 fix typo (flutter/engine#39971) (flutter/flutter#…
93fbdbb 
…121788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flar flar flar approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
2 participants
@Nayuta403 @flar