Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web engine build config cleanup. #40064

Merged
merged 1 commit into from Mar 4, 2023
Merged

Web engine build config cleanup. #40064

merged 1 commit into from Mar 4, 2023

Conversation

godofredoc
Copy link
Contributor

  • Use felt wrapper instead of felt.dart
  • Remove gclient and and autoninja from felt wrappers.
  • Add the config to .ci.yaml.

Bug: flutter/flutter#119036

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Web engine build config cleanup.
280f93a 
* Use felt wrapper instead of felt.dart
* Remove gclient and and autoninja from felt wrappers.
* Add the config to .ci.yaml.

Bug: flutter/flutter#119036
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 3, 2023
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 3, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 3, 2023

auto label is removed for flutter/engine, pr: 40064, due to - The status or check suite Linux Fuchsia FEMU has failed. Please fix the issues identified (or deflake) before re-applying this label.

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2023
@auto-submit auto-submit bot merged commit 3070e61 into flutter:main Mar 4, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 4, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2023
@engine-flutter-autoroll
3070e6157 Web engine build config cleanup. (flutter/engine#40064)
37d79b0
@godofredoc godofredoc deleted the web_engine2 branch April 6, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyebrowsoffire eyebrowsoffire eyebrowsoffire approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Milestone
No milestone
2 participants
@godofredoc @eyebrowsoffire