Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched floats to ints in gradient shaders for better performance #40189

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Switched floats to ints in gradient shaders for better performance #40189

merged 2 commits into from
Mar 9, 2023

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Mar 9, 2023 •
edited
Loading

While researching flutter/flutter#122324 I saw that this was an easy performance gain, might as well land it while we wait to remove implicit conversions.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke changed the title Removed float call from loop to test malioc output Switched floats to ints in gradient shaders for better performance Mar 9, 2023
@gaaclarke gaaclarke marked this pull request as ready for review March 9, 2023 21:24
jonahwilliams
jonahwilliams approved these changes Mar 9, 2023
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanderso we should configure malioc to run on the vulkan spv modules too

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 9, 2023
@auto-submit auto-submit bot merged commit 71c81ef into flutter:main Mar 9, 2023
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 9, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2023
@engine-flutter-autoroll
71c81ef9d Switched floats to ints in gradient shaders for better perf…
f9af569 
…ormance (flutter/engine#40189)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaclarke @jonahwilliams