Reland "Sequester all Skia<->DL interactions into the skia sub-module" #40243

flar · 2023-03-12T05:58:54Z

This reland includes fixes for some of the problems uncovered by the previous PR, including:

Fixing building with the Impeller 3D flag ([Impeller] Fix scene build #40166)
Streamlining handling of opacity on DisplayLists which may have led to some off-by-1 errors on "grayed out widgets"
Fixing a regression in a gradient rendering benchmark

flar · 2023-03-12T08:58:55Z

I'm getting a crash running some of the unit tests on my M1 MBP that don't seem to be causing the CI tests any trouble. I'm converting this to a draft until I can figure it out.

flar · 2023-03-13T08:06:17Z

The crashes were related to building with --enable-impeller-3d which is an optional engine feature for now so I'm releasing this PR for review.

flar · 2023-03-13T08:07:28Z

I should run some downstream golden tests again to make sure I've fixed the major problems first...

This reverts commit 45f6a50.

…sub-module" (flutter/engine#40243)

flar · 2023-03-14T21:03:52Z

Golden changes were identified downstream that appear to be more than off-by-1. Reverting while I investigate.

…b-module" (#40243)" This reverts commit f9f7706.

…sub-module" (flutter/engine#40243)

…b-module" (#40243)" (#40283) This reverts commit f9f7706.

…sub-module" (flutter/engine#40243)

flar force-pushed the reland-40083-2 branch from 8194a43 to bf82c58 Compare March 12, 2023 07:15

flar marked this pull request as draft March 12, 2023 08:59

flar marked this pull request as ready for review March 13, 2023 08:06

flar marked this pull request as draft March 13, 2023 08:07

flar added 6 commits March 14, 2023 01:57

Reland "Sequester all Skia<->DL interactions into the skia sub-module"

b63cf28

This reverts commit 45f6a50.

fix IMPELLER_ENABLE_3D support

f44f3f9

streamline and trace saveLayers in Sk DrawDisplayList

bfe615a

fix (and potentially improve) regression building gradient ops

3a73bcf

adjust new unittest for running with a fixture

b1dfcad

formatting

5db24cb

flar force-pushed the reland-40083-2 branch from 5d9cfb0 to 5db24cb Compare March 14, 2023 09:16

flar marked this pull request as ready for review March 14, 2023 18:05

flar requested a review from chinmaygarde March 14, 2023 18:08

chinmaygarde approved these changes Mar 14, 2023

View reviewed changes

flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 14, 2023

auto-submit bot merged commit f9f7706 into flutter:main Mar 14, 2023

engine-flutter-autoroll mentioned this pull request Mar 14, 2023

Roll Flutter Engine from e80266b78e74 to f9f7706de5e0 (1 revision) flutter/flutter#122628

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 14, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

921cca6

…sub-module" (flutter/engine#40243)

flar added a commit that referenced this pull request Mar 14, 2023

Revert "Reland "Sequester all Skia<->DL interactions into the skia su…

5be0954

…b-module" (#40243)" This reverts commit f9f7706.

flar mentioned this pull request Mar 14, 2023

Revert "Reland "Sequester all Skia<->DL interactions into the skia sub-module"" #40283

Merged

engine-flutter-autoroll mentioned this pull request Mar 14, 2023

Roll Flutter Engine from e80266b78e74 to 0513cef0ace9 (3 revisions) flutter/flutter#122638

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 14, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

36b34a8

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 14, 2023

Roll Flutter Engine from e80266b78e74 to 0513cef0ace9 (3 revisions) flutter/flutter#122641

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 14, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

aee94a4

…sub-module" (flutter/engine#40243)

flar added a commit that referenced this pull request Mar 14, 2023

Revert "Reland "Sequester all Skia<->DL interactions into the skia su…

2cf597c

…b-module" (#40243)" (#40283) This reverts commit f9f7706.

engine-flutter-autoroll mentioned this pull request Mar 14, 2023

Roll Flutter Engine from e80266b78e74 to 2cf597ce77ca (5 revisions) flutter/flutter#122648

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 14, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

0311aeb

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to cadf30ab8f13 (6 revisions) flutter/flutter#122649

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

e82f96a

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to f46d770a02f0 (7 revisions) flutter/flutter#122652

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

7b01e7f

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to 85354b5cc6c2 (8 revisions) flutter/flutter#122654

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

a9424ac

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to cbd0c10fd542 (9 revisions) flutter/flutter#122655

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

b0a49aa

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to d1934a982637 (10 revisions) flutter/flutter#122656

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

5026fe2

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to 620431def838 (11 revisions) flutter/flutter#122662

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

b2b781d

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to 620431def838 (11 revisions) flutter/flutter#122669

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

c3d7313

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to d9770af6e5eb (12 revisions) flutter/flutter#122671

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

d11b653

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to 273afb751311 (13 revisions) flutter/flutter#122675

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

b326428

…sub-module" (flutter/engine#40243)

engine-flutter-autoroll mentioned this pull request Mar 15, 2023

Roll Flutter Engine from e80266b78e74 to b7297f025972 (14 revisions) flutter/flutter#122677

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 15, 2023

f9f7706de Reland "Sequester all Skia<->DL interactions into the skia …

59c72af

…sub-module" (flutter/engine#40243)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reland "Sequester all Skia<->DL interactions into the skia sub-module" #40243

Reland "Sequester all Skia<->DL interactions into the skia sub-module" #40243

Uh oh!

flar commented Mar 12, 2023

Uh oh!

flar commented Mar 12, 2023

Uh oh!

flar commented Mar 13, 2023

Uh oh!

flar commented Mar 13, 2023

Uh oh!

flar commented Mar 14, 2023

Uh oh!

Uh oh!

Reland "Sequester all Skia<->DL interactions into the skia sub-module" #40243

Reland "Sequester all Skia<->DL interactions into the skia sub-module" #40243

Uh oh!

Conversation

flar commented Mar 12, 2023

Uh oh!

flar commented Mar 12, 2023

Uh oh!

flar commented Mar 13, 2023

Uh oh!

flar commented Mar 13, 2023

Uh oh!

flar commented Mar 14, 2023

Uh oh!

Uh oh!