This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Handle error more gracefully, add test for same #40361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
force-pushed
the
fix_exit_application
branch
from
d930c21 to
e46f3e1
Compare
cbracken
approved these changes
Mar 16, 2023
cbracken
reviewed
Mar 16, 2023
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 16, 2023
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the application exit handler so that it deals more gracefully with errors returned to it from the framework.
In this case, since the framework doesn't yet have support for requesting an application exit, it was returning an error condition, which the previous code tried to convert to an NSDictionary (and failed, causing a crash).
Now it will log the error and quit as requested if an error or unrecognized object type is returned.
Related Issues
Tests