Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use skia_enable_ganesh instead of legacy GN arg #40382

Merged
merged 1 commit into from Mar 17, 2023

Conversation

kjlubick
Copy link
Contributor

Follow-up to Skia's change http://review.skia.org/649523

Pre-launch Checklist

  • [ x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ x ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • [ x ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • [ x ] I signed the CLA.
  • [ x ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jason-simmons jason-simmons merged commit c5cc217 into flutter:main Mar 17, 2023
37 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 17, 2023
@kjlubick kjlubick deleted the update-gn branch April 10, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants