Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Turn on CanvasKit Chromium #40459

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Conversation

mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Mar 20, 2023

This is the last bit to make CanvasKit Chromium available to our users by default.

Users can always opt-out by canvasKitVariant: "full" to their runtime configuration similar to this.

_flutter.loader.loadEntrypoint({
  onEntrypointLoaded: async function(engineInitializer) {
    let appRunner = await engineInitializer.initializeEngine({
      canvasKitVariant: "full",
    });

    await appRunner.runApp();
  }
});

Closes flutter/flutter#122329

@mdebbar mdebbar requested review from kevmoo and yjbanov March 20, 2023 19:00
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Mar 20, 2023
@kevmoo
Copy link
Contributor

kevmoo commented Mar 20, 2023

Do we have full and complete documentation of all of the initializeEngine options...somewhere?

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdebbar
Copy link
Contributor Author

mdebbar commented Mar 21, 2023

Do we have full and complete documentation of all of the initializeEngine options...somewhere?

Yes, here: https://docs.flutter.dev/development/platform-integration/web/initialization#initializing-the-engine

Filed an issue to add documentation for canvasKitVariant to make sure I don't forget: flutter/flutter#123048

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 21, 2023
@auto-submit auto-submit bot merged commit 87b52f9 into flutter:main Mar 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
zanderso added a commit that referenced this pull request Mar 21, 2023
auto-submit bot pushed a commit that referenced this pull request Mar 21, 2023
Revert "[web] Turn on CanvasKit Chromium"
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 21, 2023
mdebbar added a commit to mdebbar/engine that referenced this pull request Mar 21, 2023
auto-submit bot pushed a commit that referenced this pull request Mar 22, 2023
Reland "[web] Turn on CanvasKit Chromium (#40459)"
@mdebbar mdebbar deleted the ck_chromium_on branch June 22, 2023 21:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[web] Turn on the flag for CanvasKit Chromium
3 participants