Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

(Reland) "[gn + codesign] codesign metadata for FlutterMacOS.framework.zip" #40508

Merged
merged 4 commits into from
Mar 22, 2023

Conversation

XilaiZhang
Copy link
Contributor

@XilaiZhang XilaiZhang commented Mar 22, 2023

The initial PR #35707 was reverted due to lint check failures. Lint check is now fixed and added to presubmit runs when .py files are modified.

This is the reland of the initial PR to add codesign metadata for FlutterMacOS.framework.zip

…k.zip (flutter#35707)

* embed codesign config in macos framework

* format files

* update path

* y flag for outer layer zip

* simplify structure

* format files
@XilaiZhang XilaiZhang changed the title [gn + codesign] mac code sign configuration for FlutterMacOS.framewor… (Reland) "[gn + codesign] codesign metadata for FlutterMacOS.framework.zip" Mar 22, 2023
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XilaiZhang XilaiZhang added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 22, 2023
@auto-submit auto-submit bot merged commit ccc3275 into flutter:main Mar 22, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants