Revert "Reland "Default the CanvasKit base URL to local artifacts."" #40700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
CaseyHillers
approved these changes
Mar 28, 2023
CaseyHillers
added
the
autosubmit
auto-submit
bot
deleted the
revert-40470-revert-40415-revert-40293-canvaskit-default-local
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 28, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 28, 2023
…ifacts. (#40293)" (#40470)" (flutter/engine#40700) (#123581) Roll Flutter Engine from 3d730c5c18f9 to db8da7fb8082 (1 revision)
sourcegraph-bot
pushed a commit
to sgtest/megarepo
that referenced
this pull request
Mar 28, 2023
…local artifacts. (#40293)" (#40470)" (flutter/engine#40700) (#123581) Commit: 9a7387c72e160957a70cd0971eb9554d3c0675ff
itsjustkevin
added a commit
to itsjustkevin/engine
that referenced
this pull request
Mar 28, 2023
…lutter#40293)" (flutter#40470)" (flutter#40700) Revert "Reland "Default the CanvasKit base URL to local artifacts.""
itsjustkevin
added a commit
that referenced
this pull request
Mar 28, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
… local artifacts. (#40293)" (#40470)" (flutter/engine#40700) (flutter/flutter#123581)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
… local artifacts. (#40293)" (#40470)" (flutter/engine#40700) (flutter/flutter#123581)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
… local artifacts. (#40293)" (#40470)" (flutter/engine#40700) (flutter/flutter#123581)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Mar 28, 2023
… local artifacts. (#40293)" (#40470)" (flutter/engine#40700) (flutter/flutter#123581)
harryterkelsen
pushed a commit
that referenced
this pull request
Mar 28, 2023
8 tasks
harryterkelsen
pushed a commit
that referenced
this pull request
Mar 29, 2023
8 tasks
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
… local artifacts. (#40293)" (#40470)" (flutter/engine#40700) (flutter/flutter#123581)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 10, 2023
… local artifacts. (#40293)" (#40470)" (flutter/engine#40700) (flutter/flutter#123581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40470 as it is causing local flutter web development (b/275455289)