Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use new SkImages namespace instead of legacy SkImage static functions #40761

Merged
merged 5 commits into from
Mar 30, 2023

Conversation

kjlubick
Copy link
Contributor

In https://skia-review.googlesource.com/c/skia/+/661059, Skia added a new SkImages namespace and deprecated using static functions on SkImage as part of an effort to separate the SkImage class and the GPU backends.

This PR replaces all old calls with the new calls, which should be functionally the same. It makes sure SkImage.h and SkImageGanesh.h are #included where appropriate.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-android labels Mar 29, 2023
@chinmaygarde chinmaygarde added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 30, 2023
@auto-submit auto-submit bot merged commit 293cab1 into flutter:main Mar 30, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 30, 2023
@kjlubick kjlubick deleted the skimage branch April 10, 2023 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App embedder Related to the embedder API platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants