-
Notifications
You must be signed in to change notification settings - Fork 6k
[Impeller] Reland move more files to core. #40812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was an unanswered question from @bdero on the original PR. Was that discussed out-of-band?
|
||
namespace impeller { | ||
|
||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how all the other otherwise header-only TUs are handled in impeller
Due to github magic I missed that question. The answer (I'll add it there too), is that If we add some other command type that's radically different from |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
auto label is removed for flutter/engine, pr: 40812, Failed to merge pr#: 40812 with Pull request could not be merged: Pull Request is not mergeable. |
Golden file changes are available for triage from new commit, Click here to view. |
Relands #40801
See #40811
Includes changes in #40810
This got reverted due to an unhappy merge missing an include in a modified file. Fixed that up and it should build now.