Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Reland move more files to core. #40812

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Mar 31, 2023

Relands #40801
See #40811
Includes changes in #40810

This got reverted due to an unhappy merge missing an include in a modified file. Fixed that up and it should build now.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an unanswered question from @bdero on the original PR. Was that discussed out-of-band?


namespace impeller {

//
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how all the other otherwise header-only TUs are handled in impeller

@dnfield
Copy link
Contributor Author

dnfield commented Mar 31, 2023

Due to github magic I missed that question. The answer (I'll add it there too), is that ResourceBinder's real purpose is to make sure that the generated code can depend exclusively on core and not on renderer, because renderer has shaders in it now.

If we add some other command type that's radically different from ComputeCommand and Command, we can add a different type that's like ResourceBinder but more suited to that new (currently hypothetical) command.

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #40812 at sha a803398

@chinmaygarde chinmaygarde changed the title Reland move more files to core [Impeller] Reland move more files to core. Mar 31, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Mar 31, 2023

auto label is removed for flutter/engine, pr: 40812, Failed to merge pr#: 40812 with Pull request could not be merged: Pull Request is not mergeable.

@dnfield dnfield added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2023
@flutter-dashboard
Copy link

Golden file changes are available for triage from new commit, Click here to view.

Changes reported for pull request #40812 at sha 0a11849

@dnfield dnfield deleted the fix branch May 12, 2023 05:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller will affect goldens
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants