This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Exit early on invalid gn CPU argument combos for simulators #40903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 40903, due to - The status or check suite Linux Android clang-tidy has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really foolproof, but would catch some simple mistakes.
I mistakenly tried to build an arm64 simulator build by doing
./flutter/tools/gn --simulator --unopt --mac-cpu=arm64. It generated the expected out directory (out/ios_debug_sim_unopt_arm64), but did not set the gn arguments for the simulator build and resulted in linker errors down the line.Also deletes an otherwise unused function.
fixes flutter/flutter#124067