This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Manual roll Dart SDK from 36ace2c92e0a to 0c85a16bac6d (6 revisions) #40974
Merged
zanderso
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:dart-sdk-flutter-engine-3a67f2bb-d210-4477-b98b-16a461ffb271-1680810082
Apr 6, 2023
Merged
Manual roll Dart SDK from 36ace2c92e0a to 0c85a16bac6d (6 revisions) #40974
zanderso
merged 1 commit into
flutter:main
from
skia-flutter-autoroll:dart-sdk-flutter-engine-3a67f2bb-d210-4477-b98b-16a461ffb271-1680810082
Apr 6, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manual roll requested by zra@google.com https://dart.googlesource.com/sdk.git/+log/36ace2c92e0a..0c85a16bac6d 2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-417.0.dev 2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-416.0.dev 2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-415.0.dev 2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-414.0.dev 2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-413.0.dev 2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-412.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC aam@google.com,dart-vm-team@google.com,jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
981f089
to
89bc1e6
Compare
fluttergithubbot
approved these changes
Apr 6, 2023
auto label is removed for flutter/engine, pr: 40974, due to - The status or check suite Windows Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
Awesome, thank you Zach! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 6, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 6, 2023
…124360) flutter/engine@419be0a...6e67341 2023-04-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 36ace2c92e0a to 0c85a16bac6d (6 revisions) (flutter/engine#40974) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
zhongwuzw
pushed a commit
to zhongwuzw/engine
that referenced
this pull request
Apr 14, 2023
…lutter#40974) Manual roll requested by zra@google.com https://dart.googlesource.com/sdk.git/+log/36ace2c92e0a..0c85a16bac6d 2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-417.0.dev 2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-416.0.dev 2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-415.0.dev 2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-414.0.dev 2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-413.0.dev 2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-412.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC aam@google.com,dart-vm-team@google.com,jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#124360) flutter/engine@419be0a...6e67341 2023-04-06 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 36ace2c92e0a to 0c85a16bac6d (6 revisions) (flutter/engine#40974) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual roll requested by zra@google.com
https://dart.googlesource.com/sdk.git/+log/36ace2c92e0a..0c85a16bac6d
2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-417.0.dev
2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-416.0.dev
2023-04-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-415.0.dev
2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-414.0.dev
2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-413.0.dev
2023-04-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.0.0-412.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC aam@google.com,dart-vm-team@google.com,jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md