This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Fix DrawPicture. #43446
Merged
[Impeller] Fix DrawPicture. #43446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Jul 6, 2023
dnfield
reviewed
Jul 6, 2023
impeller/aiks/canvas.cc
Outdated
| return true; | ||
| }); | ||
| return; | ||
| pass->AddSubpassInline(std::move(pass)); |
There was a problem hiding this comment.
Suggested change
| pass->AddSubpassInline(std::move(pass)); | |
| GetCurrentPass()->AddSubpassInline(std::move(pass)); |
dnfield
reviewed
Jul 6, 2023
impeller/aiks/canvas.cc
Outdated
Comment on lines
405
to
406
| auto save_count = GetSaveCount(); | ||
| Save(); |
There was a problem hiding this comment.
Move this below the early return below.
dnfield
suggested changes
Jul 6, 2023
dnfield
reviewed
Jul 6, 2023
impeller/entity/entity_pass.cc
Outdated
| return true; | ||
| } | ||
|
|
||
| void EntityPass::IterateAllElements( |
There was a problem hiding this comment.
Consider moving to separate patch, unused
dnfield
approved these changes
Jul 6, 2023
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
|
Is this part of the fixes for flutter/flutter#130078? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 6, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 7, 2023
…130107) flutter/engine@48bf7ac...491f317 2023-07-06 chinmaygarde@google.com Account for updated Impeller label. (flutter/engine#43450) 2023-07-06 bdero@google.com [Impeller] Fix DrawPicture. (flutter/engine#43446) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
No this is me nerd-sniping @bdero into fixing this the right way haha |
|
I filed flutter/flutter#130142 to track the work I'm referring to. |
kjlubick
pushed a commit
to kjlubick/engine
that referenced
this pull request
Jul 14, 2023
Prior to this patch, `DrawPicture` was untested and a no-op. We needed a new routine to absorb Elements of a cloned pass into another pass, since appending a `Picture` as a subpass would be incorrect behavior for drawing a picture (since subpasses start with a blank image, which gets drawn to and then composited with the parent pass via a separate blending operation).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch,
DrawPicturewas untested and a no-op.We needed a new routine to absorb Elements of a cloned pass into another pass, since appending a
Pictureas a subpass would be incorrect behavior for drawing a picture (since subpasses start with a blank image, which gets drawn to and then composited with the parent pass via a separate blending operation).