This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use the Clang unreachable code warning flag in the engine tree #44458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Aug 7, 2023
| result->Success(); | ||
| exit(EXIT_SUCCESS); |
There was a problem hiding this comment.
Isn't this a bug? The result is never going to have a change to sent over the channel for the other side to respond.
There was a problem hiding this comment.
Initially I figured I'd leave the result->Success there for consistency. But it does not really serve a purpose - the result will not be sent to the client after the process exits.
Removed the result->Success call`.
jason-simmons
force-pushed
the
clang-warn-unreachable
branch
from
948d46d to
3917b92
Compare
jason-simmons
force-pushed
the
clang-warn-unreachable
branch
3 times, most recently
from
8743bb5 to
941f7e6
Compare
bdero
approved these changes
Aug 8, 2023
|
|
||
| delegate->PresentTexture(texture_info); | ||
| return delegate->PresentTexture(texture_info); |
jason-simmons
force-pushed
the
clang-warn-unreachable
branch
2 times, most recently
from
1bc8801 to
822cd5b
Compare
jason-simmons
force-pushed
the
clang-warn-unreachable
branch
from
822cd5b to
7525fbc
Compare
jason-simmons
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 8, 2023
…132149) flutter/engine@22bd35a...dd03fae 2023-08-08 10456171+caroqliu@users.noreply.github.com Remove GFX branches from Flutter engine (flutter/engine#44401) 2023-08-08 jason-simmons@users.noreply.github.com Use the Clang unreachable code warning flag in the engine tree (flutter/engine#44458) 2023-08-08 skia-flutter-autoroll@skia.org Roll Skia from 66ba512c613c to 30c0319e7e42 (3 revisions) (flutter/engine#44500) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
14 tasks
gaaclarke
pushed a commit
to gaaclarke/engine
that referenced
this pull request
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.