This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reland "ios: remove shared_application and support app extension build #44732" #45351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port app extension build" (flutter#45250)" This reverts commit 367c709. fix format tests format
cyanglaz
force-pushed
the
reland_remove_shared_application
branch
from
d4ecab7 to
4a1709a
Compare
cyanglaz
commented
Aug 31, 2023
| } | ||
| // Fallback to slow implementation. | ||
| return [NSBundle bundleWithIdentifier:bundleID]; | ||
| return assets; |
There was a problem hiding this comment.
This is the fix, original PR had a url reachability test and returns nil here
| return flutterFrameworkBundle; | ||
| } | ||
|
|
||
| NSString* FLTAssetPath(NSBundle* bundle) { |
There was a problem hiding this comment.
Compares to the original PR, also refactored this method in this PR
| XCTAssertEqualObjects(bundle.bundleURL, [NSBundle mainBundle].bundleURL); | ||
| } | ||
|
|
||
| - (void)testFLTAssetsURLFromBundle { |
There was a problem hiding this comment.
This is the test for the fix
stuartmorgan-g
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
LGTM
(For future reland-with-fix PRs, something that I highly recommend is to make the PR contain two commits, one that's a straight revert-of-revert, and then a second that's the changes, so that reviewers can easily review the diff from the previous version.)
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 1, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 1, 2023
fluttermirroringbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 2, 2023
…133879) flutter/engine@d00b69a...489c399 2023-09-01 matanlurey@users.noreply.github.com Update (flipping the default from false -> true) and deprecate Paint.enableDithering. (flutter/engine#44705) 2023-09-01 jonahwilliams@google.com [Impeller] EntityPass::Clone needs to clone harder (flutter/engine#45313) 2023-09-01 ychris@google.com Reland "ios: remove shared_application and support app extension build #44732" (flutter/engine#45351) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
…48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR #45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
LinXunFeng
added a commit
to LinXunFeng/engine
that referenced
this pull request
Nov 27, 2023
…lutter#48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR flutter#45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style (cherry picked from commit bec0dac)
harryterkelsen
pushed a commit
to harryterkelsen/engine
that referenced
this pull request
Nov 27, 2023
…lutter#48271) Fix flutter/flutter#138604 and flutter/flutter#138671 Related PR flutter#45351 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relands #44732 with fix.
The original PR returns nil when the assets is not reachable, in some cases, the assets are not loaded yet but will be loaded later, so we should return the asset URL regardless.
Also added a fallback to main bundle to match the previous implementation.
The original PR was failed in internal tests in b/297654739
Now with the fix, all tests passed: cl/561449914
fixes flutter/flutter#124289
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.