This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Exclude frontend_server from the license crawl #4645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The thinking is that we need to keep track only of the licenses of the artifacts that ends up the users mobile device(rather than a flutter developer's workstation)? |
|
We have to keep track of all the licenses, but the license script itself generates the LICENSE file only for the engine-specific bits that end up in the APK or IPA file. |
|
(Having said that, this should have no impact on the actual license.) |
|
|
alexmarkov
added a commit
to flutter/flutter
that referenced
this pull request
Feb 9, 2018
Includes: * Exclude frontend_server from the license crawl (flutter/engine#4645) * Make native wrapper classes non-abstract (flutter/engine#4607) * Restrict clang-format to C, C++, Obj-C, Obj-C++ (flutter/engine#4654)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
Includes: * Exclude frontend_server from the license crawl (flutter/engine#4645) * Make native wrapper classes non-abstract (flutter/engine#4607) * Restrict clang-format to C, C++, Obj-C, Obj-C++ (flutter/engine#4654)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.