This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Use flutter mirrors for non-google origin deps instead of fuchsia #48735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
|
Changing to draft in order to resolve adding patches not yet present to the new flutter mirrors which is likely the reason for these failures |
|
Took a bit to figure out the applying patches + removing the auto-overwriting updates fetched from the upstream to the mirror, but they are now configured just as fuchsia's are and should be good to go. |
zanderso
approved these changes
Dec 14, 2023
sealesj
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 15, 2023
…140221) flutter/engine@9524a18...986a6fe 2023-12-15 103135467+sealesj@users.noreply.github.com Use flutter mirrors for non-google origin deps instead of fuchsia (flutter/engine#48735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have configured mirrors with the same configuration as other flutter mirrors (e.g. public read access, hosted on flutter GoB) for the fuchsia github dependencies coming from non-google origin. The same patches are applied to these as in fuchsia GoB.
This change is to rely on the flutter mirrors instead of fuchsia so that possible breaking changes made to fuchsia mirrors in the future will not affect flutter. Context and tracking can be found in this bug: b/313921121
Github deps from google origins are not being migrated to a new flutter mirror here because google is creating its own mirrors for those deps. We will migrate deps included in the new mirrors after it is set up. (context: b/274009025)
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.