Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Impeller] made sure to scale the blur radius by the effect transform #49645

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jan 9, 2024

fixes flutter/flutter#141204

screenshot after pr

Screenshot 2024-01-09 at 2 31 10 PM

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke changed the title [Impeller] made sure to scale he blur radius by the effect transform [Impeller] made sure to scale the blur radius by the effect transform Jan 9, 2024
@gaaclarke gaaclarke marked this pull request as ready for review January 9, 2024 22:41
Copy link
Member

@bdero bdero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 9, 2024
@gaaclarke gaaclarke merged commit 941f268 into flutter:main Jan 9, 2024
27 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 10, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 10, 2024
…141224)

flutter/engine@542fea9...941f268

2024-01-09 30870216+gaaclarke@users.noreply.github.com [Impeller] made sure to scale the blur radius by the effect transform (flutter/engine#49645)
2024-01-09 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Refactors RBE support" (flutter/engine#49654)
2024-01-09 zanderso@users.noreply.github.com Refactors RBE support (flutter/engine#49416)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[Impeller] new blur doesn't handle effect transform properly
2 participants