Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "[Impeller] Encode directly to command buffer for Vulkan." #49818

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Jan 17, 2024

Reverts #49780
Initiated by: jonahwilliams
This change reverts the following previous change:
Original Description:
Part of flutter/flutter#140804

Rather than using impeller::Command, the impeller::RenderPass records most state directly into the Vulkan command buffer. This should remove allocation/free overhead of the intermediary structures and make further improvements to the backend even easier. This required a number of other changes to the renderer:

  1. The render pass holds a strong ptr to the context. This helps avoid locking continually while encoding, which is quite slow.
  2. barriers need to be encoded on the producing side, and not the consuming side. This is because we'll actually run the consuming code before the producing code. i.e. we transition to shader read at the end of a render pass instead of when binding.
  3. I've updated the binding code to also provide the descriptor type so that we don't need to look it up from the desc. set.
  4. I added a test render pass class that records commands.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jan 17, 2024
@auto-submit auto-submit bot merged commit 73a2de5 into main Jan 17, 2024
6 checks passed
@auto-submit auto-submit bot deleted the revert_602c35496d7fb617afb5538f2ec52db6ea05512a branch January 17, 2024 01:18
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 17, 2024
zanderso pushed a commit to flutter/flutter that referenced this pull request Jan 17, 2024
…ions) (#141667)

Manual roll requested by zra@google.com

Cannot build log URL because revision "73a2de5da53f" is invalid: Luci
builds of "Mac builder_cache" for
73a2de5da53f8ab133e88b43d05189879c370cb3 was INFRA_FAILURE

2024-01-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts
"[Impeller] Encode directly to command buffer for Vulkan."
(flutter/engine#49818)
2024-01-17 zanderso@users.noreply.github.com Revert "Add
gclient_variables back for linux_license and fix the excluded files"
(flutter/engine#49817)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e: impeller revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants