Change how OpenGL textures are flipped in the Android embedder. #49938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test-exempt: Test will live in another repo |
|
@matanlurey This patch is correct, but it turns out there's also a bug in |
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 23, 2024
…142027) flutter/engine@9e582c9...37f68f6 2024-01-23 matanlurey@users.noreply.github.com Change how OpenGL textures are flipped in the Android embedder. (flutter/engine#49938) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 23, 2024
Document some confusing bits of `geometry` for the next bub. Originally this PR was to add a test and fix a bug, but that's being handled here: #49938.
matanlurey
added a commit
to matanlurey/engine
that referenced
this pull request
Jan 29, 2024
…r. (flutter#49938)" This reverts commit 37f68f6.
matanlurey
added a commit
that referenced
this pull request
Jan 30, 2024
…er" (#50158) Reverts #49938. This broke `packages/packages/camera/camera/example`, and unfortunately there is no test (in engine, framework, or packages) that would have caught this. We also suspect (but are not sure) that this is related to an internal customer reported bug as well (b/322750489). --- Here is the output _pre_-revert:  Here is the output _post_-revert: 
CaseyHillers
pushed a commit
to CaseyHillers/engine
that referenced
this pull request
Jan 30, 2024
…er" (flutter#50158) Reverts flutter#49938. This broke `packages/packages/camera/camera/example`, and unfortunately there is no test (in engine, framework, or packages) that would have caught this. We also suspect (but are not sure) that this is related to an internal customer reported bug as well (b/322750489). --- Here is the output _pre_-revert:  Here is the output _post_-revert: 
auto-submit bot
pushed a commit
that referenced
this pull request
Jan 30, 2024
…mbedder" (#50176) (#50158) b/322916882 Reverts #49938. This broke `packages/packages/camera/camera/example`, and unfortunately there is no test (in engine, framework, or packages) that would have caught this. We also suspect (but are not sure) that this is related to an internal customer reported bug as well (b/322750489). --- Here is the output _pre_-revert:  Here is the output _post_-revert: 
matanlurey
added a commit
that referenced
this pull request
Feb 7, 2024
20337ea (now reverted) intentionally re-introduced a bug (#49938) on a now working test runner, and verified that (with some fixes in this PR), we can now catch regressions on CI with SkiaGold: --- <details> <summary>ExternalTextureTests_testCanvasSurface.png</summary> This test shows that what previously was a picture has been reduced down to a single stretched pixel. **BEFORE**:  **AFTER**:  </details> <details> <summary>ExternalTextureTests_testRotatedMediaSurface_180.png</summary> Similar to above, but shows _another_ bug (kClamp versus kRepeat) **BEFORE**:  **AFTER**: /cc </details> --- This PR now makes the `scenario_test` useful and blocking for Android engine rolls: - Add support for connecting to SkiaGold by depending on `goldctl` in the appropriate configs. - Add some useful local debugging flags for skipping SkiaGold or running specific tests (not used by default). - Failing to connect to Skia gold is now a test failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
h/t @bdero for writing the actual code (I just wrote comments).
Manual test1 of
cd packages/packages/video_player/video_player/example && flutter run:Skia
Impeller + OpenGL
Closes flutter/flutter#141636.
Footnotes
I can't write a test worth writing at the same time of this PR, so I've filed https://github.com/flutter/flutter/issues/141973 to do it after. ↩