Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run engine unit tests on mac host_debug_unopt_arm64 #50327

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

zanderso
Copy link
Member

@zanderso zanderso commented Feb 3, 2024

@zanderso
Copy link
Member Author

zanderso commented Feb 7, 2024

Copying this out before I hit retry: From: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/689309/overview

[ RUN      ] Play/BlitPassTest.BlitAcrossDifferentPixelFormatsFails/Metal
-[MTLDebugDevice newTextureWithDescriptor:]:1017: failed assertion `Texture Descriptor Validation
Memoryless texture need to have renderable PixelFormat.

@chinmaygarde
Copy link
Member

Can we file issues for the failing validations?

@jonahwilliams
Copy link
Member

I'm just going to push fixes to this PR.

@jonahwilliams
Copy link
Member

@zanderso I think the remaining failure is a builder config problem?

Running command "python3 test.py"
Traceback (most recent call last):
  File "test.py", line 51, in <module>
    raise Exception(
Exception: Could not locate font-subset in host_debug or host_debug_unopt - build before running this script.

@jonahwilliams
Copy link
Member

See also: flutter/flutter#143324

@zanderso
Copy link
Member Author

@zanderso I think the remaining failure is a builder config problem?

Yeah, that looks like the font-subset test script is hardcoding some strings that should be arguments instead. I can take a look at that.

@zanderso zanderso force-pushed the impeller-unittests-m1 branch 2 times, most recently from 1245e4b to 0cd3fa1 Compare February 22, 2024 04:07
@zanderso
Copy link
Member Author

zanderso commented Feb 22, 2024

I've cleaned up an fixed the font-subset test script. The last remaining failure is EmbedderTest.CompositorMustBeAbleToRenderKnownSceneWithSoftwareCompositor, which I'm not sure how to address. It looks like an ad-hoc pixel test.

I filed flutter/flutter#143940

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zanderso !

@zanderso

This comment was marked as outdated.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually you blew away my patch to fix the test by force pushing.

@zanderso
Copy link
Member Author

Actually you blew away my patch to fix the test by force pushing.

Ooooops

@jonahwilliams
Copy link
Member

The fix is to change the failing test to the following:

TEST_P(BlitPassTest, BlitAcrossDifferentPixelFormatsFails) {
  ScopedValidationDisable scope;  // avoid noise in output.
  auto context = GetContext();
  auto cmd_buffer = context->CreateCommandBuffer();
  auto blit_pass = cmd_buffer->CreateBlitPass();

  TextureDescriptor src_desc;
  src_desc.format = PixelFormat::kA8UNormInt;
  src_desc.size = {100, 100};
  src_desc.storage_mode = StorageMode::kHostVisible;
  auto src = context->GetResourceAllocator()->CreateTexture(src_desc);

  TextureDescriptor dst_format;
  dst_format.format = PixelFormat::kR8G8B8A8UNormInt;
  dst_format.size = {100, 100};
  dst_format.storage_mode = StorageMode::kHostVisible;
  auto dst = context->GetResourceAllocator()->CreateTexture(dst_format);

  EXPECT_FALSE(blit_pass->AddCopy(src, dst));
}

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 27, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 27, 2024
…144208)

flutter/engine@04ff286...0bc21ea

2024-02-27 matanlurey@users.noreply.github.com Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989)
2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter/engine#50998)
2024-02-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996)
2024-02-27 matanlurey@users.noreply.github.com Fix usage of `--out-dir` with a relative path. (flutter/engine#50992)
2024-02-27 jason-simmons@users.noreply.github.com Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter/engine#50991)
2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994)
2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate Android `scenario_app` to the `SurfaceProducer` API (#50993)" (flutter/engine#50995)
2024-02-27 matanlurey@users.noreply.github.com Migrate Android `scenario_app` to the `SurfaceProducer` API (flutter/engine#50993)
2024-02-27 dkwingsmt@users.noreply.github.com Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985)
2024-02-26 matanlurey@users.noreply.github.com Refactor args parsing/environment constructor for `scenario_app` (flutter/engine#50980)
2024-02-26 jonahwilliams@google.com [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981)
2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983)
2024-02-26 skia-flutter-autoroll@skia.org Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979)
2024-02-26 zanderso@users.noreply.github.com Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327)
2024-02-26 jonahwilliams@google.com [Impeller] disble render pass caches. (flutter/engine#50976)
2024-02-26 john@johnmccutchan.com Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971)
2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883)
2024-02-26 matanlurey@users.noreply.github.com Better filtering for Android `scenario_app` runner. (flutter/engine#50937)
2024-02-26 jacksongardner@google.com Make sure to call `setHeightOverride` as well on TextStyle and StrutStyle (flutter/engine#50920)
2024-02-26 jacksongardner@google.com Correctly offset the cull rect of the opacity layer. (flutter/engine#50928)
2024-02-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from kLvCWEgbL1VT to JCdhkDSFXzHy

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants