-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run engine unit tests on mac host_debug_unopt_arm64 #50327
Conversation
77cff67
to
dae4259
Compare
Copying this out before I hit retry: From: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20Engine%20Drone/689309/overview
|
40b5df4
to
6fc8824
Compare
Can we file issues for the failing validations? |
6fc8824
to
73a3a81
Compare
I'm just going to push fixes to this PR. |
@zanderso I think the remaining failure is a builder config problem?
|
See also: flutter/flutter#143324 |
Yeah, that looks like the font-subset test script is hardcoding some strings that should be arguments instead. I can take a look at that. |
1245e4b
to
0cd3fa1
Compare
I've cleaned up an fixed the font-subset test script. The last remaining failure is I filed flutter/flutter#143940 |
ed5cd34
to
651fb5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zanderso !
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually you blew away my patch to fix the test by force pushing.
Ooooops |
The fix is to change the failing test to the following:
|
651fb5e
to
6055d7b
Compare
…144208) flutter/engine@04ff286...0bc21ea 2024-02-27 matanlurey@users.noreply.github.com Respect SIGINT (Ctrl-C) for Android scenario_app. (flutter/engine#50989) 2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from aa28c3a30a98 to 2f2a718b27f7 (1 revision) (flutter/engine#50998) 2024-02-27 skia-flutter-autoroll@skia.org Roll Dart SDK from 2876f5684ced to 67b2a250747b (1 revision) (flutter/engine#50996) 2024-02-27 matanlurey@users.noreply.github.com Fix usage of `--out-dir` with a relative path. (flutter/engine#50992) 2024-02-27 jason-simmons@users.noreply.github.com Roll buildroot to 21b1b9f2645fada701885108e86aefbcb3b1cca0 (flutter/engine#50991) 2024-02-27 skia-flutter-autoroll@skia.org Roll Skia from ba3ed5998af3 to aa28c3a30a98 (12 revisions) (flutter/engine#50994) 2024-02-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Migrate Android `scenario_app` to the `SurfaceProducer` API (#50993)" (flutter/engine#50995) 2024-02-27 matanlurey@users.noreply.github.com Migrate Android `scenario_app` to the `SurfaceProducer` API (flutter/engine#50993) 2024-02-27 dkwingsmt@users.noreply.github.com Revert "Reland 4: Multiview pipeline (#50931)" (flutter/engine#50985) 2024-02-26 matanlurey@users.noreply.github.com Refactor args parsing/environment constructor for `scenario_app` (flutter/engine#50980) 2024-02-26 jonahwilliams@google.com [scenario] trigger firstFrameLatch on exception. (flutter/engine#50981) 2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a misspelling and name mismatch in a shader test fixture (flutter/engine#50983) 2024-02-26 skia-flutter-autoroll@skia.org Roll Dart SDK from c479735adcf9 to 2876f5684ced (2 revisions) (flutter/engine#50979) 2024-02-26 zanderso@users.noreply.github.com Run engine unit tests on mac host_debug_unopt_arm64 (flutter/engine#50327) 2024-02-26 jonahwilliams@google.com [Impeller] disble render pass caches. (flutter/engine#50976) 2024-02-26 john@johnmccutchan.com Update Surface reference after resizing render target in VirtualDisplay based platform views (flutter/engine#50971) 2024-02-26 jason-simmons@users.noreply.github.com [Impeller] Fix a race that can abort the process if the Vulkan context is destroyed while pipeline creation tasks are pending (flutter/engine#50883) 2024-02-26 matanlurey@users.noreply.github.com Better filtering for Android `scenario_app` runner. (flutter/engine#50937) 2024-02-26 jacksongardner@google.com Make sure to call `setHeightOverride` as well on TextStyle and StrutStyle (flutter/engine#50920) 2024-02-26 jacksongardner@google.com Correctly offset the cull rect of the opacity layer. (flutter/engine#50928) 2024-02-26 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from kLvCWEgbL1VTRW69e... to JCdhkDSFXzHyPuP4I... (flutter/engine#50970) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from kLvCWEgbL1VT to JCdhkDSFXzHy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Related flutter/flutter#142868