[Impeller] blur: hold on to 1/8 downsample until the kernel overflows #50363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
force-pushed
the
max-out-1_8-blur
branch
from
71e9b0e
to
bdf4079
Compare
gaaclarke
force-pushed
the
max-out-1_8-blur
branch
from
bdf4079
to
76e1121
Compare
gaaclarke
changed the title
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 6, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 6, 2024
…142959) flutter/engine@9c1b6c9...8088863 2024-02-06 30870216+gaaclarke@users.noreply.github.com [Impeller] blur: hold on to 1/8 downsample until the kernel overflows (flutter/engine#50363) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: flutter/flutter#142753
After #50262 there were still some sigmas that could show shimmering around the sigma [50, 100] range which had a downsample amount of 1/16. This makes those ranges hang on to 1/8 for as long as possible. I'm unable to see any shimmering with
AiksTest.GaussianBlurAnimatedBackdropafter this PR. I've also expanded that test so the clip region could be scaled to make sure that there aren't sizes which cause it to reappear.Testing: Expanded on manual testing. Since the error only manifests when evaluating multiple frames of rendering we don't have infrastructure to test that.
Here is the graph of
GaussianBlurFilterContents::CalculateScaleafter this change:Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.