Add Impeller runtime options to Android `scenario_app` #50487

matanlurey · 2024-02-09T03:00:54Z

Closes flutter/flutter#143171.

Adds builds for both Impeller Vulkan and Impeller OpenGLES.

Some of the goldens for Impeller/Vulkan won't look right yet. I'll link to the blocking issues after CI runs.

testing/scenario_app/bin/android_integration_tests.dart

zanderso

Nice.

zanderso · 2024-02-09T03:54:13Z

ci/builders/linux_android_emulator.json

@@ -72,9 +72,51 @@
                    "contexts": [
                        "android_virtual_device"
                    ],
-                    "script": "flutter/testing/scenario_app/run_android_tests.sh",
+                    "script": "flutter/testing/scenario_app/run_android_tests.sh --graphics-backend=skia",


Is there a reason that --graphics-backend=skia is in the script string and not the parameters list below? Like, is this working around a bug in the engine_v2 recipe?

Looks like the presub is failing because the flag does indeed need to go in the parameter list rather than in the script string.

dnfield

Please remove gradle wrapper. We should not be downloading gradle via gradle wrapper in this repo, it can contribute to flakiness.

Consider naming this flag similarly to the tool, e.g. --enable-impeller or --no-enable-impeller rather than introducing another similar flag.

dnfield · 2024-02-09T17:19:49Z

testing/scenario_app/android/gradle/wrapper/gradle-wrapper.properties

Specifcially remove this file.

Gradle is specified in DEPS.

Hmm that is in conflict with:
https://discord.com/channels/608014603317936148/846507907876257822/1205260372668452947

... should I add this to gitignore, or?

I agree with Dan. Since there's been a big escalation in the flake rate recently due to the gradle wrapper failing to download gradle due to rate limiting and other network errors, I don't think we should go that route.

Sounds good.

matanlurey · 2024-02-12T18:50:42Z

The flutter-gold bot did not flag the additional variants, maybe I need to do something else?

        dimensions: <String, String>{
          'AndroidAPILevel': connectedDeviceAPILevel,
          'GraphicsBackend': enableImpeller ? 'impeller=${impellerBackend!.name}' : 'skia',

kjlubick · 2024-02-12T21:10:07Z

The flutter-gold bot did not flag the additional variants, maybe I need to do something else?

        dimensions: <String, String>{
          'AndroidAPILevel': connectedDeviceAPILevel,
          'GraphicsBackend': enableImpeller ? 'impeller=${impellerBackend!.name}' : 'skia',

GraphicsBackend skia appears to have made it in. Is your question "why don't I see the impeller key" also?

matanlurey · 2024-02-12T21:11:43Z

@kjlubick I expected:

To have to approve skia coded images (because previously they didn't have a key)
To see and approve impeller-vulkan and impeller-opengles variants

kjlubick · 2024-02-12T21:17:28Z

@kjlubick I expected:

To have to approve skia coded images (because previously they didn't have a key)
Gold only has "image digest" + "grouping" (test name + corpus) in the triaged expectations. The new key does not require a new triage action.

To see and approve impeller-vulkan and impeller-opengles variants
Unless the images are different, you shouldn't expect to see these show up as "untriaged". If you have some tests in mind, you can check the "Postive", "Negative", "Untriaged" boxes and then use the trace filter to search by "name" to see if those new keys do show up on those tests.

jonahwilliams

LGTM!

…tter/engine#50487)

…sions) (#143380) Manual roll Flutter Engine from 1c3ecee77350 to 920874bf2c1a (34 revisions) Manual roll requested by jonahwilliams@google.com Cannot build log URL because revision "920874bf2c1a" is invalid: Luci builds of "Linux Fuchsia FEMU" for 920874bf2c1a9ba2e9b7260b79ede8f1e26ea4f0 was FAILURE 2024-02-13 dnfield@google.com Do not use AChoreographer on 32 bit devices (flutter/engine#50586) 2024-02-13 zanderso@users.noreply.github.com Move libpng to //flutter/third_party/libpng (flutter/engine#50571) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from b150107d536d to aaed347b2dbb (2 revisions) (flutter/engine#50595) 2024-02-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 8d3a8d85c883 to 105312b80125 (2 revisions) (flutter/engine#50593) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from d503bc9c6e46 to b150107d536d (1 revision) (flutter/engine#50591) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from a1d9b83034ac to d503bc9c6e46 (3 revisions) (flutter/engine#50587) 2024-02-13 30870216+gaaclarke@users.noreply.github.com [Impeller] cleaned up and removed golden test exceptions (flutter/engine#50572) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from 17d00f9241b3 to a1d9b83034ac (2 revisions) (flutter/engine#50582) 2024-02-13 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RVHAIKU50ogkiV-Lj... to l6mWjvlO1xJg5ZFKK... (flutter/engine#50579) 2024-02-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 94f7dec34cef to 8d3a8d85c883 (1 revision) (flutter/engine#50577) 2024-02-13 matanlurey@users.noreply.github.com Add Impeller runtime options to Android `scenario_app` (flutter/engine#50487) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from c464143dfaab to 17d00f9241b3 (1 revision) (flutter/engine#50576) 2024-02-13 skia-flutter-autoroll@skia.org Roll Skia from ecf2f622d0b3 to c464143dfaab (2 revisions) (flutter/engine#50574) 2024-02-12 jonahwilliams@google.com [Impeller] CommandPoolVK recycles command buffers too. (flutter/engine#50468) 2024-02-12 matanlurey@users.noreply.github.com Make `dart:ui#Paint` `final` to allow changes/disallow implementing. (flutter/engine#50557) 2024-02-12 robert.ancell@canonical.com Replace usage of an integer for GdkModifierType (flutter/engine#50481) 2024-02-12 robert.ancell@canonical.com Remove FlKeyEvent.dispose_origin and use GdkEvent type for origin (flutter/engine#50483) 2024-02-12 zanderso@users.noreply.github.com Move Linux impeller_unittests to linux_unopt (flutter/engine#50558) 2024-02-12 chinmaygarde@google.com [Impeller] Don't suppress outdated validation error. (flutter/engine#50568) 2024-02-12 chinmaygarde@google.com [Impeller] Remove references to moved impeller/image from README. (flutter/engine#50513) 2024-02-12 skia-flutter-autoroll@skia.org Roll Dart SDK from dca13675e65e to 94f7dec34cef (1 revision) (flutter/engine#50567) 2024-02-12 skia-flutter-autoroll@skia.org Roll Skia from f88eeb658358 to ecf2f622d0b3 (1 revision) (flutter/engine#50566) 2024-02-12 skia-flutter-autoroll@skia.org Roll Skia from 867c1e8390e2 to f88eeb658358 (5 revisions) (flutter/engine#50564) 2024-02-12 jason-simmons@users.noreply.github.com Roll vulkan-deps to 014f44e134a1de387791bffacc32ff9d8db71176 (flutter/engine#50515) 2024-02-12 skia-flutter-autoroll@skia.org Roll Skia from 4081496b7693 to 867c1e8390e2 (20 revisions) (flutter/engine#50562) 2024-02-12 jonahwilliams@google.com [Impeller] force render pass construction on all backends to ensure image layout is transitioned/render pass state setup. (flutter/engine#50539) 2024-02-12 737941+loic-sharma@users.noreply.github.com [Windows] Make the view own its EGL surface (flutter/engine#50421) 2024-02-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 5c9e79e66364 to dca13675e65e (1 revision) (flutter/engine#50559) 2024-02-12 1889916+miguelfrde@users.noreply.github.com [fuchsia] Update Inspect library usage (flutter/engine#50467) 2024-02-12 zanderso@users.noreply.github.com Initializes RBE in the build config runner (flutter/engine#50543) 2024-02-12 tugorez@users.noreply.github.com Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward] (flutter/engine#50533) 2024-02-12 dnfield@google.com Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests (flutter/engine#50540) 2024-02-12 30870216+gaaclarke@users.noreply.github.com [Impeller] deleted the old blur (flutter/engine#50470) 2024-02-12 kjlubick@users.noreply.github.com Update codec defines for Skia (flutter/engine#50554) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from RVHAIKU50ogk to l6mWjvlO1xJg If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jonahwilliams@google.com,jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. ...

matanlurey added 4 commits February 8, 2024 13:14

Add a flag for the runner, check-in gradle-wrapper.properties.

784fbcc

Remove OpenGLES for now since it does not have a flag.

7a34c48

Try adding an Impeller backend.

b65077a

Javafmt.

6cba705

matanlurey marked this pull request as draft February 9, 2024 03:01

matanlurey marked this pull request as ready for review February 9, 2024 03:01

jonahwilliams reviewed Feb 9, 2024

View reviewed changes

testing/scenario_app/bin/android_integration_tests.dart Show resolved Hide resolved

Add OpenGLES too.

6ace602

matanlurey requested review from jonahwilliams, dnfield and gaaclarke February 9, 2024 03:09

zanderso reviewed Feb 9, 2024

View reviewed changes

dnfield suggested changes Feb 9, 2024

View reviewed changes

dnfield reviewed Feb 9, 2024

View reviewed changes

matanlurey added 2 commits February 12, 2024 08:46

Address feedback.

fbff725

++

282410c

matanlurey changed the title ~~Add a --graphics-backend option to Android scenario_app, run Impeller as well as Skia~~ Add Impeller runtime options to Android scenario_app Feb 12, 2024

matanlurey requested review from zanderso and dnfield February 12, 2024 16:47

zanderso approved these changes Feb 12, 2024

View reviewed changes

matanlurey added 2 commits February 12, 2024 11:23

Remove gradle-wrapper as-per feedback.

9db854c

Fix dimension name maybe?

4cbabf1

matanlurey added 2 commits February 12, 2024 13:22

Tweak logging to understand output better.

8dfc6b0

Actually pass the arguments.

385969b

jonahwilliams approved these changes Feb 13, 2024

View reviewed changes

dnfield approved these changes Feb 13, 2024

View reviewed changes

matanlurey merged commit 7e20016 into flutter:main Feb 13, 2024
28 checks passed

matanlurey deleted the engine-android_scenario_app-impeller branch February 13, 2024 01:59

engine-flutter-autoroll mentioned this pull request Feb 13, 2024

Manual roll Flutter Engine from 1c3ecee77350 to 920874bf2c1a (34 revisions) flutter/flutter#143380

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 13, 2024

7e20016ad Add Impeller runtime options to Android scenario_app (flu…

f0e4a35

…tter/engine#50487)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Impeller runtime options to Android `scenario_app` #50487

Add Impeller runtime options to Android `scenario_app` #50487

matanlurey commented Feb 9, 2024 •

edited

Loading

zanderso left a comment

zanderso Feb 9, 2024

zanderso Feb 9, 2024

dnfield left a comment

dnfield Feb 9, 2024

matanlurey Feb 12, 2024

zanderso Feb 12, 2024

matanlurey Feb 12, 2024

matanlurey commented Feb 12, 2024

kjlubick commented Feb 12, 2024

matanlurey commented Feb 12, 2024 •

edited

Loading

kjlubick commented Feb 12, 2024

jonahwilliams left a comment

Add Impeller runtime options to Android scenario_app #50487

Add Impeller runtime options to Android scenario_app #50487

Conversation

matanlurey commented Feb 9, 2024 • edited Loading

zanderso left a comment

Choose a reason for hiding this comment

zanderso Feb 9, 2024

Choose a reason for hiding this comment

zanderso Feb 9, 2024

Choose a reason for hiding this comment

dnfield left a comment

Choose a reason for hiding this comment

dnfield Feb 9, 2024

Choose a reason for hiding this comment

matanlurey Feb 12, 2024

Choose a reason for hiding this comment

zanderso Feb 12, 2024

Choose a reason for hiding this comment

matanlurey Feb 12, 2024

Choose a reason for hiding this comment

matanlurey commented Feb 12, 2024

kjlubick commented Feb 12, 2024

matanlurey commented Feb 12, 2024 • edited Loading

kjlubick commented Feb 12, 2024

jonahwilliams left a comment

Choose a reason for hiding this comment

Add Impeller runtime options to Android `scenario_app` #50487

Add Impeller runtime options to Android `scenario_app` #50487

matanlurey commented Feb 9, 2024 •

edited

Loading

matanlurey commented Feb 12, 2024 •

edited

Loading