Fail lazily when 1+ Skia gold comparions fail. #51010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .catchError((dynamic err) { | ||
| panic(<String>['skia gold comparison failed: $err']); | ||
| .catchError((Object error) { | ||
| logWarning('skia gold comparison failed: $error'); |
There was a problem hiding this comment.
Not sure what was happening when you threw from an error handler block. Seems reasonable to try
zanderso
approved these changes
Feb 27, 2024
matanlurey
added
the
autosubmit
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 28, 2024
2461280c38 Roll Fuchsia Linux SDK from JCdhkDSFXzHyPuP4I... to T1xAi_ww_mWEiDkVN... (flutter/engine#51011) 8940ea0887 Code consistency fixes in FlScrollingManager (flutter/engine#50959) 21474ee4a4 [macOS] Use CVDisplayLink to drive repaint (flutter/engine#49159) 6f7b939568 Fail lazily when 1+ Skia gold comparions fail. (flutter/engine#51010) 249daf5512 Adjust Android emulator test timeouts (flutter/engine#51004)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Speculative) fix for flutter/flutter#144238.
@zanderso Could you review from a CLI angle? I realize this code is not great, but could I do something better here?