[Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc #51234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 6, 2024
Other repos are not using the same mechanism (//build/fuchsia/sdk_override.txt), so this change allows the location to be specified via an environment variable, which is likely a common and universal solution. It will be used by flutter/engine#51234. Bug: b/328110079 Change-Id: Ia6741830df9aebeb59ea9d212ec66307b5763df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5347216 Commit-Queue: Zijie He <zijiehe@google.com> Reviewed-by: David Song <wintermelons@google.com> Cr-Commit-Position: refs/heads/main@{#1269191}
zijiehe-google-com
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
approved these changes
Mar 8, 2024
zijiehe-google-com
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 8, 2024
…144839) flutter/engine@bc4abcd...05fdf94 2024-03-08 jonahwilliams@google.com [Impeller] More efficient usage of transient onscreen attachments. (flutter/engine#51206) 2024-03-08 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Providing FUCHSIA_SDK_PATH env var for fuchsia lsc (flutter/engine#51234) 2024-03-08 chris@bracken.jp Migrate vulkan_memory_allocator to flutter/third_party (flutter/engine#51275) 2024-03-08 jason-simmons@users.noreply.github.com Update CI scripts to use either src/flutter/third_party/dart or src/third_party/dart (flutter/engine#51276) 2024-03-08 kustermann@google.com Add fuchsia_gn_sdk GN variable pointing to //flutter/tools/fuchsia/gn-sdk (flutter/engine#51287) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 993a88a663c8 to a4fb847f47d9 (1 revision) (flutter/engine#51283) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 15f8d03a9594 to 993a88a663c8 (1 revision) (flutter/engine#51282) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from 093994f8f078 to 15f8d03a9594 (1 revision) (flutter/engine#51280) 2024-03-08 skia-flutter-autoroll@skia.org Roll Skia from bf3f9c5f0edb to 093994f8f078 (1 revision) (flutter/engine#51278) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates test-scripts with https://crrev.com/c/5347216 so that it can override the sdk location from an env var. The override location can be used by update_product_bundles to download emulator images of an unreleased sdk from gcs buckets. The process is used by fuchsia lsc (https://ci.chromium.org/ui/p/turquoise/builders/global.ci/sdk-core-linux-flutter), now it's failing due to the wrong product_bundle location being used.
This change should have no impact to the existing builders since they do not use either gclient variables relevant. E.g. download_fuchsia_sdk and fuchsia_sdk_path.
Bug: http://b/328110079
FYI: @mbrase
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.