This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Reverts "Replace WindowInsetsController... with adb shell commands (#51843)"
#51847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![auto-submit[bot]](https://avatars.githubusercontent.com/u/14101776?s=60&v=4){kind=small}
auto-submit
bot
added
the
revert of
fluttergithubbot
approved these changes
Apr 2, 2024
auto-submit
bot
deleted the
revert_061717894dd8731fe8a5e53561e8f396806f3b4c
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 2, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 2, 2024
…146152) flutter/engine@6883f73...5bf8b94 2024-04-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Replace `WindowInsetsController...` with `adb shell` commands (#51843)" (flutter/engine#51847) 2024-04-02 matanlurey@users.noreply.github.com Replace `WindowInsetsController...` with `adb shell` commands (flutter/engine#51843) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC matanl@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #51843
Initiated by: matanlurey
Reason for reverting: broke tree because the bottom bar now shows up.
Original PR Author: matanlurey
Reviewed By: {jonahwilliams}
This change reverts the following previous change:
Previously our screenshots looked like this (when they ran correctly):
Now, sometimes (only on CI unfortunately) they look like this:
This started happening after #51832, but the change should be future-proof as well even if we disable the screen recording feature.
h/t @reidbaker