Move verbose to environment.verbose, pass to ninja --verbose if provided.
#52619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
May 7, 2024
| @@ -66,13 +66,13 @@ void main(List<String> args) async { | |||
| platform: const LocalPlatform(), | |||
| processRunner: ProcessRunner(), | |||
| logger: Logger(), | |||
| verbose: verbose, | |||
There was a problem hiding this comment.
Optional: as a further cleanup, the verbosity could just be encoded in the log level of the Logger() on the line above. It's currently set in https://github.com/flutter/engine/blob/main/tools/engine_tool/lib/src/commands/command_runner.dart#L106, but could just as well be set here.
There was a problem hiding this comment.
I think this makes sense, but probably what I would do is something like Logger(verbose: true) and have Logger set itself up versus trying to overload Logger's log severity (where verbose isn't really a thing) with the app-wide verbosity flag.
Let me send a follow-up PR and we can chomp on that a bit.
matanlurey
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/52619, due to - The status or check suite Linux linux_unopt has failed. Please fix the issues identified (or deflake) before re-applying this label. |
matanlurey
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
May 7, 2024
…r. (#52624) Based on @zanderso's feedback here: #52619 (comment). I think this is the most succinct way to setup logging, it also doesn't seem to make sense to allow the level to be configured at runtime, so boom.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
…erbose` if provided. (flutter/engine#52619)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2024
…147943) flutter/engine@42898e0...1fe835b 2024-05-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add host_profile_arm64 and host_release_arm64 local engine configurations. (#52620)" (flutter/engine#52630) 2024-05-07 matanlurey@users.noreply.github.com Move `verbose` to `environment.verbose`, pass to `ninja --verbose` if provided. (flutter/engine#52619) 2024-05-07 chinmaygarde@google.com Add host_profile_arm64 and host_release_arm64 local engine configurations. (flutter/engine#52620) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#147894.
While doing this PR I realized we were basically passing
(bool verbose, Envrionment)as a tuple around, so I just moved the concept intoEnvironmentdirectly, and made the necessary code changes across the tool and tests.To clarify, this does not mimic the output of
ninja --verbosetoday, because we also don't stream the output directly, and instead do terminal magic. Combined with a hypothetical fix for flutter/flutter#147903, this would work exactly the same as before./cc @loic-sharma @johnmccutchan