Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "Add host_profile_arm64 and host_release_arm64 local engine configurations. (#52620)" #52630

Merged
merged 1 commit into from
May 7, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented May 7, 2024

Reverts: #52620

Initiated by: zanderso

Reason for reverting: Builds timing out in post submit. I think we should try relanding this with --no-lto passed to gn.

Original PR Author: chinmaygarde

Reviewed By: {zanderso}

This change reverts the following previous change:
These are used on macOS hosts during local engine development.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label May 7, 2024
@auto-submit auto-submit bot merged commit 1fe835b into main May 7, 2024
6 of 7 checks passed
@zanderso
Copy link
Member

zanderso commented May 7, 2024

cc @chinmaygarde

@auto-submit auto-submit bot deleted the revert_7cc54f99017ed6eafe967d6f4c6850324348f852 branch May 7, 2024 20:34
@chinmaygarde
Copy link
Member

Relanding in #52633

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request May 7, 2024
…147943)

flutter/engine@42898e0...1fe835b

2024-05-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add host_profile_arm64 and host_release_arm64 local engine configurations. (#52620)" (flutter/engine#52630)
2024-05-07 matanlurey@users.noreply.github.com Move `verbose` to `environment.verbose`, pass to `ninja --verbose` if provided. (flutter/engine#52619)
2024-05-07 chinmaygarde@google.com Add host_profile_arm64 and host_release_arm64 local engine configurations. (flutter/engine#52620)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants