[Impeller] Disable aging in the AHB swapchains and use FILO. #52637
Conversation
The aging was causing elevated 9x percentile times after a long duration where no frames were rendered. The FILO queue behavior gives the fences the most time possible to signal and cause fewer GPU stalls. There are already no CPU stalls.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| desc_(desc), | ||
| max_entries_(max_entries), | ||
| max_extry_age_(max_extry_age) { | ||
| size_t max_entries) |
There was a problem hiding this comment.
I think two is too small of a number, or we should potentially let it float above max_entries without GC. We can handle that as a follow up.
impeller/renderer/backend/vulkan/swapchain/ahb/ahb_texture_pool_vk.cc
Outdated
Show resolved
Hide resolved
chinmaygarde
added
the
autosubmit
…147954) flutter/engine@d8dd731...1c52274 2024-05-07 chinmaygarde@google.com [Impeller] Disable aging in the AHB swapchains and use FILO. (flutter/engine#52637) 2024-05-07 matanlurey@users.noreply.github.com Move `Logger.test` to an injected log output versus leaky abstraction. (flutter/engine#52639) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The aging was causing elevated 9x percentile times after a long duration where no frames were rendered. The FILO queue behavior gives the fences the most time possible to signal and cause fewer GPU stalls. There are already no CPU stalls.