add SemanticsAction.focus #53094
Merged
add SemanticsAction.focus #53094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-web
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 29, 2024
…149274) These tests essentially count the number of values in the engine enums. flutter/engine#53094 is adding a new value, which causes these tests to fail. Temporarily disabling these tests so that the engine change can proceed.
gspencergoog
approved these changes
May 30, 2024
| @@ -201,6 +207,50 @@ class SemanticsAction { | |||
| /// movement should extend (or start) a selection. | |||
| static const SemanticsAction moveCursorBackwardByWord = SemanticsAction._(_kMoveCursorBackwardByWordIndex, 'moveCursorBackwardByWord'); | |||
|
|
|||
| /// Move the input focus to the respective widget. | |||
| /// | |||
| /// Most commonly, the input focus determines what widget will receive | |||
There was a problem hiding this comment.
Suggested change
| /// Most commonly, the input focus determines what widget will receive | |
| /// Most commonly, the input focus determines which widget will receive |
There was a problem hiding this comment.
Oops! I slapped on the autosubmit label without realizing that my git push failed 🤦 I'll send the doc fix in a separate PR.
chunhtai
approved these changes
May 30, 2024
| /// | ||
| /// * [didGainAccessibilityFocus], which informs the framework about | ||
| /// accessibility focus ring, such as the TalkBack (Android) and | ||
| /// VoiceOver (iOS), moving which does not move the input focus. |
There was a problem hiding this comment.
Do we have an issue to migrate desktop embedding to respect the system settings whether to sync focus and a11y focus?
There was a problem hiding this comment.
I guess flutter/flutter#83809 does technically cover it. However, I think we can split out platform-specific issues so they can be addressed one by one by the relevant teams. I'll do the web part.
yjbanov
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
chingjun
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 30, 2024
…149357) flutter/engine@de07179...bf2e32d 2024-05-30 flar@google.com DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (#53119)" (flutter/engine#53128) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126) 2024-05-30 jonnywang@google.com Fuchsia api level 18 (flutter/engine#53115) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (#53099)" (flutter/engine#53125) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (#53108)" (flutter/engine#53124) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120) 2024-05-30 skia-flutter-autoroll@skia.org Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119) 2024-05-30 yjbanov@google.com add SemanticsAction.focus (flutter/engine#53094) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117) 2024-05-30 bdero@google.com [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114) 2024-05-30 jiahaog@users.noreply.github.com Disable Impeller when the manifest explicitly disables it (flutter/engine#53108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149274) These tests essentially count the number of values in the engine enums. flutter/engine#53094 is adding a new value, which causes these tests to fail. Temporarily disabling these tests so that the engine change can proceed.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
May 31, 2024
…lutter#149357) flutter/engine@de07179...bf2e32d 2024-05-30 flar@google.com DisplayList SaveLayer (and root layer) read-back flags (flutter/engine#53104) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 7cfb0898ac15 to 188ad395c3e7 (2 revisions) (flutter/engine#53127) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter#53119)" (flutter/engine#53128) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 75cf7d351b02 to 7cfb0898ac15 (3 revisions) (flutter/engine#53126) 2024-05-30 jonnywang@google.com Fuchsia api level 18 (flutter/engine#53115) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] enable Impeller by default on Android. (flutter#53099)" (flutter/engine#53125) 2024-05-30 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Disable Impeller when the manifest explicitly disables it (flutter#53108)" (flutter/engine#53124) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from eadc654480ed to 75cf7d351b02 (2 revisions) (flutter/engine#53120) 2024-05-30 skia-flutter-autoroll@skia.org Roll Dart SDK from ef405fbe3917 to 2976c1694eed (6 revisions) (flutter/engine#53119) 2024-05-30 yjbanov@google.com add SemanticsAction.focus (flutter/engine#53094) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 693d9362f0f6 to eadc654480ed (3 revisions) (flutter/engine#53117) 2024-05-30 bdero@google.com [Flutter GPU] Upload `flutter_gpu.zip` upon successful completion of ci/android_debug. (flutter/engine#53107) 2024-05-30 skia-flutter-autoroll@skia.org Roll Skia from 949b8cefbf87 to 693d9362f0f6 (2 revisions) (flutter/engine#53114) 2024-05-30 jiahaog@users.noreply.github.com Disable Impeller when the manifest explicitly disables it (flutter/engine#53108) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SemanticsAction.focus. This PR just adds the new enum value without any logic. Adding the enum value first to unblock work that needs to be done on both the engine and framework side that will actually implement all the necessary logic.This is PR 1 out of ~3 for flutter/flutter#83809