[Impeller] actually fix external texture for GLES. #55414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
jonahwilliams
changed the title
|
This is tested via goldens. |
|
Okay now its working, PTAL @matanlurey |
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 26, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 26, 2024
…155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…lutter#155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 27, 2024
…lutter#155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 1961493+harryterkelsen@users.noreply.github.com Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 matanlurey@users.noreply.github.com Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 jonahwilliams@google.com [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 jonahwilliams@google.com [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 jessiewong401@gmail.com Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 30870216+gaaclarke@users.noreply.github.com Fixes blend + color filter (flutter/engine#55411) 2024-09-25 matanlurey@users.noreply.github.com Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 jonahwilliams@google.com [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 bdero@google.com [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 skia-flutter-autoroll@skia.org Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 30870216+gaaclarke@users.noreply.github.com adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 skia-flutter-autoroll@skia.org Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 matanlurey@users.noreply.github.com Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goldens are working! and incorrect! use the other texture contents to hopefully fix them. Ratther the the transform, we actually expect to use the src and dst rect to position/transform the texture. Tiled Texture contents does not support a src rect, so switch it to the regular texture contents.