Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

matthew-carroll
Copy link
Contributor

Android Embedding PR 16: Add touch support to FlutterView.

My test app now registers touch events as expected.

Copy link
Contributor

@mklim mklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java style LGTM pending one nit.

Copy link
Member

@jason-simmons jason-simmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit edfc0cf into flutter:master Mar 9, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 9, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Mar 9, 2019
flutter/engine@c48774c...03d5f3c

git log c48774c..03d5f3c --no-merges --oneline
03d5f3c Clarify arguments to FlutterEngineOnVsync (flutter/engine#8093)
718329c Android Embedding PR 17: Clarify AccessibilityBridge and move logic out of FlutterView. (flutter/engine#8061)
edfc0cf Android Embedding PR 16: Add touch support to FlutterView. (flutter/engine#8034)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop
the roller if necessary.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants