Add read-only persistent cache #8049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
reviewed
Mar 6, 2019
| @@ -539,6 +539,10 @@ typedef struct { | |||
| // Flutter application (such as compiled shader programs used by Skia). | |||
| // This is optional. The string must be NULL terminated. | |||
| const char* persistent_cache_path; | |||
|
|
|||
| // If true, we'll only read the existing cache, but not write new ones. | |||
| bool is_persistent_cache_read_only; | |||
There was a problem hiding this comment.
Instead of "we", please say "the engine". Also, we should only read this field if the persistent_cache_path is non-null.
There was a problem hiding this comment.
Changed "we" to "engine".
Shall we also allow read-only cache for the default cache path where persistent_cache_path is nullptr?
There was a problem hiding this comment.
I dont think so. On Linux, the default cache path is empty and the persistent cache wont be setup in such cases.
chinmaygarde
approved these changes
Mar 7, 2019
liyuqian
force-pushed
the
read-only-cache
branch
from
3923e9e
to
692af11
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 8, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Mar 9, 2019
flutter/engine@6031407...87edd94 git log 6031407..87edd94 --no-merges --oneline 87edd94 Add read-only persistent cache (flutter/engine#8049) 4c94049 Move android_sdk_downloader so I can more easily deprecate it (flutter/engine#8084) 7cbd9d8 Roll src/third_party/skia 3d1b941f3a7d..bea1f94f341e (7 commits) (flutter/engine#8083) 260669c Fix deleting text when the last character is some special characters on IOS (flutter/engine#7982) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (mklim@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients (e.g., embedded devices) prefer generating persistent cache files for the specific device beforehand, and ship them as readonly files in OTA packages.