This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Pipe Z bounds from ViewportMetrics to Flow #8583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step in making Flutter aware of and responsive to Z bound overflow. On its own this patch shouldn't result in any changes in behavior. This will need to be followed up with a patch in Fuchsia's Flutter runner to set the Z bounds after this lands, and another patch in the engine actually implementing the desired overflow behavior. This Z bound info is routed through the engine itself to make sure the bounds in flow are truly consistent from the Fuchsia runner. However there should be another patch exposing these values to the framework for Flutter devs to see as well.
|
Can you link the embedder side patch for this too? Just so it's easier to see the full code flow. |
No problem. https://fuchsia-review.googlesource.com/c/topaz/+/272353 |
chinmaygarde
approved these changes
Apr 16, 2019
liyuqian
suggested changes
Apr 16, 2019
liyuqian
reviewed
Apr 16, 2019
liyuqian
approved these changes
Apr 16, 2019
added 2 commits
April 16, 2019 14:56
Move the setter into PhysicalShapeLayer. Remove the getter completely. Replace it with a key on the PrerollContext struct.
liyuqian
reviewed
Apr 17, 2019
liyuqian
approved these changes
Apr 17, 2019
Thanks for the quick review responses! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 17, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 17, 2019
flutter/engine@fdd4272...523a9a9 git log fdd4272..523a9a9 --no-merges --oneline 523a9a9 Add FLEPluginRegistry for macOS (flutter/engine#8611) dd9dcaf [fuchsia] Fix SceneUpdateContext for new PaintContext field (flutter/engine#8608) 0e27e0f Pipe Z bounds from ViewportMetrics to Flow (flutter/engine#8583) f62ab83 Roll src/third_party/dart f0da03ca36..bc99f1ca28 (1 commits) 7b38aef Roll src/third_party/skia 33906ad1e26f..5155e09d1466 (4 commits) (flutter/engine#8609) b0dedbd Roll src/third_party/dart d9c40462c2..f0da03ca36 (1 commits) f88ba6e Roll src/third_party/skia e88d4382e1cf..33906ad1e26f (1 commits) (flutter/engine#8604) 53c0905 Roll src/third_party/skia 652b007a4cbb..e88d4382e1cf (4 commits) (flutter/engine#8603) 4266f85 Add desktop shell unittests to test script (flutter/engine#8600) 8156268 Roll src/third_party/dart 8e73b3c006..d9c40462c2 (4 commits) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in making Flutter aware of and responsive to Z
bound overflow. On its own this patch shouldn't result in any changes in
behavior. This will need to be followed up with a patch in Fuchsia's
Flutter runner to set the Z bounds after this lands, and another patch
in the engine actually implementing the desired overflow behavior.
This Z bound info is routed through the engine itself to make sure the
bounds in flow are truly consistent from the Fuchsia runner. However
there should be another patch exposing these values to the framework for
Flutter devs to see as well.
flutter/flutter#25226