This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow building without python2 #8605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all of the python build files in the flutter project work if `python` is `python2` or `python3`. This is the only area where print is incorrectly used (for `python3`). Related issue: https://fuchsia-review.googlesource.com/c/fuchsia/+/272925
jason-simmons
approved these changes
Apr 17, 2019
|
It looks like the luci-engine failures are just existing flakes |
chinmaygarde
approved these changes
Apr 18, 2019
|
The tree was red for a bit earlier today which is why the LUCI check was red. It seems to have cleared now. Thanks for the patch. Landing. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 18, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 18, 2019
flutter/engine@8b5a50c...7006870 git log 8b5a50c..7006870 --no-merges --oneline 7006870 Allow building without python2 (flutter/engine#8605) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all of the python build files in the flutter project work if
pythonispython2orpython3. This is the only area where print isincorrectly used (for
python3).Related issue: https://fuchsia-review.googlesource.com/c/fuchsia/+/272925